Adds affine and track_stats params to BatchNorm docstring #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhairyaLGandhi
previously approved these changes
Oct 1, 2021
Member
DhairyaLGandhi
left a comment
DhairyaLGandhi
left a comment
There was a problem hiding this comment.
Thanks! This lgtm, would you mind adding it for the other norm layers too?
Co-authored-by: Dhairya Gandhi <dhairya@juliacomputing.com>
Contributor
Author
Another layers already have these parameters in docstring |
DhairyaLGandhi
approved these changes
Oct 1, 2021
Member
|
Ah, thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 1, 2021
1729: Adds affine and track_stats params to BatchNorm docstring r=DhairyaLGandhi a=Mottl ### PR Checklist - [ ] Tests are added - [ ] Entry in NEWS.md - [*] Documentation, if applicable - [ ] API changes require approval from a committer (different from the author, if applicable) Co-authored-by: Dmitry Mottl <dmitry.mottl@gmail.com>
Contributor
|
Timed out. |
Member
|
Seems like our GPU CI queue is backed up. |
Contributor
Author
|
ping :-) |
Member
|
bors r+ |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist