New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the training callback with `throttle` function #52

Merged
merged 2 commits into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@ylxdzsw
Contributor

ylxdzsw commented Jul 21, 2017

No description provided.

@MikeInnes

This comment has been minimized.

Member

MikeInnes commented Jul 25, 2017

Great, can you add a couple of tests for the implemented options? Can just be for throttle rather than the training process.

Given how you're using later, could that just be a bool?

@ylxdzsw

This comment has been minimized.

Contributor

ylxdzsw commented Jul 25, 2017

later also holds args and kwargs, but actually we don't pass anything. Should we just assume f has no arguments?

@MikeInnes

This comment has been minimized.

Member

MikeInnes commented Jul 25, 2017

When you call later, args and kwargs are in scope, so you can just use them.

@ylxdzsw

This comment has been minimized.

Contributor

ylxdzsw commented Jul 25, 2017

When trailling option is enabled and a successive call happens more frequently than timeout with different args, there will be only one Task created at the first call in line 50, and the args catched by the closure is the args of the first call, but it should be the ones of the last call.

@MikeInnes

This comment has been minimized.

Member

MikeInnes commented Jul 25, 2017

Ah, I see what you mean. That's the sort of thing that's great to have a test for so I don't break it in future :)

@MikeInnes MikeInnes merged commit a1b7434 into FluxML:master Aug 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment