Added the fundamental spaces #7
Conversation
…into Base-structure
src/Spaces/discrete.jl
Outdated
| Discrete(N::Int) = new(N, Int64) | ||
| end | ||
|
|
||
| sample(self::Discrete) = rand(1:self.n) |
There was a problem hiding this comment.
self -> d (or anything else which would imply that given object is a Discrete when read)
There was a problem hiding this comment.
@tejank10 A little confused here. Are you suggesting something like sample(discrete_obj::Discrete) = rand(1:discrete_obj.n)?
There was a problem hiding this comment.
Yeah, something like that.
| as_int = Int.(x) | ||
| catch InexactError | ||
| return false | ||
| end |
src/Spaces/multi-binary.jl
Outdated
|
|
||
| sample(self::MultiBinary) = (self.dtype).(rand(0:1, self.n)) | ||
|
|
||
| contains(self::MultiBinary, x) = all(boolor.(x .== 0, x .== 1)) |
There was a problem hiding this comment.
Any particular reason for introducing boolor? Can we do all(x .== 0 .| x .== 1)?
There was a problem hiding this comment.
Sorry about that, I was just testing something and I forgot to remove that function. Consider it fixed...
src/Spaces/multi-binary.jl
Outdated
|
|
||
| contains(self::MultiBinary, x) = all(boolor.(x .== 0, x .== 1)) | ||
|
|
||
| Base.:(==)(self::MultiBinary, other::MultiBinary) = return self.n == other.n |
There was a problem hiding this comment.
return can be dropped here
|
@tejank10 Made changes as requested. Please review and verify. |
|
Great! I intend to replace CartPole with CartPole1.1, if the examples in model-zoo are not breaking. |
|
Made the necessary changes. Please verify. |
|
Great work @kraftpunk97 , Thanks! |
|
I have never experienced joy like this before. Thanks for sticking it out with me. |
PR with reference to this issue #5
seed and copy functions still need to be implemented. Modified CartPole.jl (CartPole-v1.1.jl) to run on these spaces.