Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjoints for UnitUpperTriangular. #442

Merged
merged 2 commits into from Jan 3, 2020
Merged

Add adjoints for UnitUpperTriangular. #442

merged 2 commits into from Jan 3, 2020

Conversation

@aterenin
Copy link
Contributor

aterenin commented Jan 2, 2020

This adds adjoints for UnitUpperTriangular and UnitLowerTriangular. For these types, adjoints are zero on the diagonal and other half of the matrix.

@MikeInnes

This comment has been minimized.

Copy link
Member

MikeInnes commented Jan 3, 2020

Could you add a gradient check? Otherwise looks good, thanks.

@aterenin aterenin force-pushed the aterenin:master branch from 1432797 to a8575df Jan 3, 2020
@MikeInnes

This comment has been minimized.

Copy link
Member

MikeInnes commented Jan 3, 2020

👍 Thanks!

bors r+

bors bot added a commit that referenced this pull request Jan 3, 2020
Merge #442
442: Add adjoints for UnitUpperTriangular. r=MikeInnes a=aterenin

This adds adjoints for UnitUpperTriangular and UnitLowerTriangular. For these types, adjoints are zero on the diagonal and other half of the matrix.

Co-authored-by: Alexander Terenin <aterenin@users.noreply.github.com>
Co-authored-by: aterenin <aterenin@users.noreply.github.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Jan 3, 2020

Build succeeded

@bors bors bot merged commit a8575df into FluxML:master Jan 3, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.