Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URGENT!! Gut tree structure is super-hard to use #124

Closed
SianGramates opened this issue Oct 6, 2017 · 4 comments · Fixed by #220
Closed

URGENT!! Gut tree structure is super-hard to use #124

SianGramates opened this issue Oct 6, 2017 · 4 comments · Fixed by #220
Assignees
Labels
enhancement additional information/better organisation for existing terms urgent important issue that needs to be fixed as a priority

Comments

@SianGramates
Copy link

adult midgut region FBbt:00110888 has is_a relationship to gut section FBbt:00100315 which has is_a relationship to organ system subdivision FBbt:00007330

It has is_a children of the various adult midgut regions Rx

adult midgut region FBbt:00110888 has part_of relationship to adult gut FBbt:00007513, but NOT to adult midgut FBbt:00003138. It has NO part_of children.

There's a huge multi-lab high-throughput expression project that we'd really like to use valid FBbt terms. These users would be using both the adult midgut regions Rx terms, and terms such as enteroblast FBbt:00110205 (part_of adult midgut).

We're concerned that if these users have to be, effectively, super-expert users of the Vocabularies tool to figure out that adult midgut region is not ontologically part_of adult midgut, and that they need to be a different relationship hierarchy (I find it highly non-intuitive that midgut regions aren't part-of the midgut!). Is there some way to make the adult midgut regions part_of the adult midgut?

@SianGramates
Copy link
Author

Lynn points out that the is_a children of midgut constriction FBbt:00000457 and adult midgut constriction FBbt:00110913 have the same issue: they're not part_of midgut or adult midgut, respectively.

@temjones temjones added anatomy enhancement additional information/better organisation for existing terms urgent important issue that needs to be fixed as a priority labels Nov 6, 2017
@temjones temjones self-assigned this Nov 6, 2017
@dosumis dosumis removed the VFB related to the nervous system/requested by VFB label Nov 21, 2017
@temjones temjones removed their assignment Feb 21, 2018
@dosumis
Copy link
Collaborator

dosumis commented Apr 23, 2018

adult midgut region FBbt:00110888 has part_of relationship to adult gut FBbt:00007513, but NOT to adult midgut FBbt:00003138

That looks to like an error to me. Ditto constrictions.

@Clare72 - you could fix this by adding logical defs to the general terms.

@dosumis
Copy link
Collaborator

dosumis commented May 1, 2018

Adult partonomy now looks good:

image

image

But generic & embryonic/larval gut terms are still a bit messy - should be harmonised with adult as far as possible.

We should look at possibilities for using logical defs to align.

(It may be worth turning this into an epic and making subtickets to track fixing.)

@dosumis
Copy link
Collaborator

dosumis commented May 1, 2018

(Screenshots in previous post may be a little out of date - will fix).

VFB Ontology work automation moved this from backlog to Done Jul 4, 2018
@Clare72 Clare72 removed this from done in VFB Ontology work Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement additional information/better organisation for existing terms urgent important issue that needs to be fixed as a priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants