Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: Fneufneu/xbmc
...
head fork: Fneufneu/xbmc
Checking mergeability… Don't worry, you can still create the pull request.
Commits on May 17, 2012
@anssih anssih [osx] added: show endianness for kAudioFormat60958AC3
As per Core Audio data types reference, endianness is defined for
kAudioFormat60958AC3 format. Show it in log similarly to PCM
formats.
4d4d662
@anssih anssih added: 16-bit buffer byteswap function in EndianSwap a60574b
@anssih anssih [AE] added: perform byteswap in raw mode if sink requires it
The sink may need raw audio data either in S16_LE or S16_BE format.

Currently the code assumes that the sink takes S16_NE. However, this may
not be the case, and especially on big-endian systems the sink may need
S16_LE instead (if the audio hardware takes that instead of S16_BE).

Therefore, perform a late byteswap if needed.

It would be preferred to take this into account in the IEC-61937 packer
already, so that we wouldn't consume CPU power byteswapping padding
(which there can be a lot of) or byteswap twice. However, the IEC-61937
packer can't currently get that information from the engine/sink.
9df032a
@anssih anssih [AE] fixed: allow ALSA passthrough with non-native data format
The ALSA sink currently only tries SND_PCM_FORMAT_S16 for passthrough.
However, the non-native endianness format is not tried. The most common
case when this is needed is big-endian systems that commonly have an
ALSA device that still takes in S16_LE.

Fix that by trying both formats for passthrough if SND_PCM_FORMAT_S16
fails.
cd3fa45
@anssih anssih [AE] removed: incorrect comment in AEConvert
A comment says that the output is always machine byte endian, but that
doesn't seem to be the case since there are specific functions for both
endian formats.

Remove the comment.
1d42f5e
@anssih anssih [AE] fixed: passthrough of LE DTS, pre-padded DTS, invalid DTS
AEPackIEC61937 currently doesn't take into account that LE DTS needs to
be byteswapped to BE format (in addition to any other byteswaps) before
being transmitted to the receiver, as only the BE format is standard and
supported by all receivers. Code comment says that the "DTS spec shows
it suppors both BE and LE", but in reality there is no provision for LE
in the DTS specification.

Additionally, AEPackIEC61937 doesn't properly handle DTS streams that
are pre-padded for S/PDIF transmission. Such streams fit exactly into
the output S/PDIF stream and no padding or IEC61937 wrapping is needed
(there is not enough space for those, either).

Also, frame size is not validated properly. Valid DTS frame sizes
in the range [ BurstPeriod-BurstHeader+1 , BurstPeriod-1 ] cannot be
packed into IEC 61937 as there is no space for the burst header.
Currently the code crashes with such inputs.

Fix all three issues by adding code handling them.
941eae2
@anssih anssih [osx] fixed: incorrect mFormatFlags set for S16LE
CCoreAudioUnit::GetFormatDesc() currently sets
kAudioFormatFlagsNativeEndian for AE_FMT_S16LE.

However, S16LE is always little-endian, not native-endian, so that flag
shouldn't be set.

This incorrect value presumably didn't cause widespread issues because
on little-endian systems S16LE is also native-endian, so the code did
nothing (as kAudioFormatFlagsNativeEndian is zero), and on big-endian
systems we normally output S16BE instead of S16LE, so the codepath was
not hit.
35e3ba0
Commits on May 20, 2012
@anssih anssih rewritten: ALSA device enumeration and selection code
The current ALSA device enumeration code steps through all the hardware
ALSA cards and devices while trying to guess the symbolic "hdmi" and
"iec958" names that will be used with ALSA. It misses any virtual
devices, such as "pulse" or "default". In addition, it didn't have any
handling for "surroundXX", which is needed on many cards to get
multi-channel analog output. Also, it didn't find "iec958" devices that
have no separate hardware device from the analog device, like on USB
sound cards.

Solve those issues by rewriting the ALSA device handling code to use the
ALSA device name hints to determine which devices should be used. This
is the same method "aplay -L" uses.

The code will automatically use the correct front/surround40/surround51/
surround71 device depending on the amount of channels requested. This is
achieved with a magic "@" in the beginning of the device string, which
will be replaced with the wanted base device name ("front",
"surround51", etc.). In addition, the "sysdefault" and "default"
dmix-enabled (allowing shared usage) outputs will be automatically used
when available, for stereo streams that have the same sample rate as the
ALSA dmix mixer has (normally 48000Hz).

The enumeration code will now add a preferred "Default" device, which is
the ALSA default device. This allows XBMC to follow the system-wide
configuration, so that when the user e.g. modifies /etc/asound.conf or
changes environment variables ($ALSA_CARD etc.), XBMC will follow those.
The device name of the "Default" device will be either "default" or "@",
depending on if the default device needs "surroundXX" mangling for
multichannel support (normal analog devices need it, but if the ALSA
default is e.g. the pulseaudio sound server, it is not needed nor
wanted).

Also, additional differentation (device number and/or card id) is now
added to the device names when identical names were found by
enumeration.

Additionally, the AES parameters are now set even when not using
passthrough for S/PDIF and HDMI devices as specified by IEC 60958.
The code will fallback to not setting the parameters since it may
sometimes fail if e.g. using a custom device that does not accept them.

The behavior of setting parameters (channel count, sample rate) is not
altered.
4c1bcc7
@anssih anssih added: log wrapper for ALSA errors b73081c
Commits on Jun 03, 2012
@eriklundberg eriklundberg Since the CRarFile::Exist method looks for files in the rar cache, it…
… might return false positives when a file exists in the cache but not in the filesystem.

This commit fixes that problem by adding a check to the RarFile::Exists method, checking for the file in the filesystem using the CFile::Exists-method. If so; it continues by looking for the file in the archive, else it returns false.
98366cc
Commits on Jul 05, 2012
Andrei G fix for bug #13098: Do not show PAUSE while skipping a paused track 2ec24bb
Commits on Jul 07, 2012
Jonathan Marshall splits saving of auth details out of CPasswordManager::PromptForAuthe…
…ntication
870c888
Jonathan Marshall strip added smb:// shares of their user/pass when adding, and instead…
… store that info in the password manager
16d4661
Commits on Jul 09, 2012
Jonathan Marshall Revert "CDatabase: remember the databases we already updated and don'…
…t check them on every connect/open"

This reverts commit d78c7195cc81babdd048737b412b99a0848f4c7c.
a80621f
Jonathan Marshall pass the db name to CDatabase::Connect rather than altering DatabaseS…
…ettings::name
614714b
Jonathan Marshall get rid of unneeded UpdateVersion when creating a new database, and d…
…rop the fallback to sqlite - it's unlikely that the sqlite db is in any way in sync with the mysql one
3e93cc5
Jonathan Marshall factor out CDatabase::GetDBVersion f656311
Jonathan Marshall factor out the Update() function in CDatabase::Open fd165ea
Jonathan Marshall factor out the initializing of database settings from CDatabase::Open adc1313
Jonathan Marshall adds new CDatabaseManager, and allow it to access CDatabase::Update d…
…irectly.
7e05bb2
Jonathan Marshall Initialize the database manager on start and on change of profile, so…
… that database updates are attempted only once rather than on every Open().
0d0eb55
Commits on Jul 10, 2012
@huceke huceke changed use also intrinsic for cas f63e817
@bossanova808 bossanova808 Fix for playfromhere context menu item - the item shouldn't need a vi…
…deo info tag for this option to be available.
06e389d
@Karlson2k Karlson2k Fix for CNfoFile is looking only for same language scrapers as defaul…
…t scraper and only if "scrapers.langfallback" is true when processing url .nfo files

Seems that this logic was from old builds and wasn't updated.
fb5c8e2
@Karlson2k Karlson2k Get rid of unused "scrapers.langfallback" setting 13a34b0
@Montellese Montellese videodb: fix UNIQUE INDEX on tag.strTag for MySQL 9ab38b3
@Montellese Montellese add GUI_MSG_SET_TEXT and support it in CGUIEditControl and CGUIDialog…
…Keyboard
99e0bcf
@Montellese Montellese jsonrpc: add Input.SendText 15de540
@Montellese Montellese jsonrpc: add Input.ExecuteAction f87c0b0
@Montellese Montellese jsonrpc: add Input.ShowCodec/ShowOSD 68e0347
@Montellese Montellese jsonrpc: add Input.OnInputRequested and Input.OnInputFinished notific…
…ations
1c9f832
@Montellese Montellese fix library/video/movies/tags.xml 87ba9ea
@Montellese Montellese set the content of the tags list to "tags" instead of "movies" b8d49ca
@davilla davilla Merge pull request #1142 from huceke/use-intrinsic-atomics
changed use also intrinsic for cas
0ed0f26
@davilla davilla change AE definition and usage of GetCacheTime to match how it is use…
…d in players
78a424d
@davilla davilla Merge pull request #1131 from davilla/fix-ae-getcachetime
change AE definition and usage of GetCacheTime to match how it is used in players
8ac5a86
@Montellese Montellese CGUIDialogNumeric: handle GUI_MSG_SET_TEXT and add new SetMode() meth…
…od which takes the initial value as a CStdString instead of a void*
9740905
@Montellese Montellese jsonrpc: send Input.OnInputRequested/OnInputFinished from CGUIDialogN…
…umeric as well
4c5310b
@anssih anssih Merge pull request #976 from anssih/fix/AE-ca-s16le
[osx] fixed: incorrect mFormatFlags set for S16LE
6380a84
@anssih anssih Merge pull request #987 from anssih/AE-alsa-dev-rewrite
Rewrite ALSA device enumeration and selection code
2de2058
@anssih anssih Merge pull request #973 from anssih/fix/AE-byteswap
[AE] Fix issues related to endianness in passthrough

Conflicts:
	xbmc/cores/AudioEngine/Engines/SoftAE/SoftAE.cpp
55e2317
Jonathan Marshall only nag about a music rescan if there is music in the library e7240d7
Commits on Jul 11, 2012
@Schischu Schischu Allow compiling without mysql dependency (--disable-mysql).
MySQL is heavy and sqlite is the better choice on embedded devices.
Disables also build of cmyth as it depends on mysql.
2d79579
Cory Fields mysql: don't show myth protocol if we don't have mysql support dc88df0
Jonathan Marshall [SoftAE] change RunOutputStage to take in a boolean for audio (vs sil…
…ence) and to return the number of samples taken by the output stage
f5a89c1
Jonathan Marshall [SoftAE] don't process silence when we don't have to. ff3a880
Cory Fields [SoftAE] pass audio/silence down to the sink so it can decide if it w…
…ants to output
74ba6a5
@theuni theuni Merge pull request #1138 from theuni/dirty_audio
Dirty audio

1. Don't have AE constantly converting and otherwise wasting resources when there is no sound output. Saves a boatload of cpu usage on embedded platforms.

2. Pass the status from 1 down to the sinks, so that they can choose to be smarter when there's nothing to do.

Note that for 2, we don't actually change any sink behaviors, only give them the knowledge of whether the buffer contains silence or real audio. Some sinks may be able to do nothing, while others may have to keep silence flowing. I'll leave that to the various platform devs.
c1cecb9
@wsoltys wsoltys [WIN32] changed: no need for a NULL check here anymore because native…
… GetCurrentThread() won't return NULL.
cb48318
@wsoltys wsoltys [WIN32] fixed compilation after c1cecb9 3d7ed17
@Montellese Montellese Merge pull request #1056 from Montellese/jsonrpc_sendkey
JSON-RPC SendKey, ExecuteAction, ShowCodec and ShowOSD in Input namespace
c924204
@JezzX JezzX Changed: [Confluence] set the default fan art background image aspect…
… ratio from stretch to scale so it maintains the correct aspect if your using anything but 16x9 aspect, 16x9 users wont notice any difference fixes #13171
8f63757
spiff cosmetics
alpha, replace tab with spaces
c0ed148
spiff [AE] clean up headers
- remove some circular includes
- remove forwarding of already defined classes
- use forwarding where possible
- remove unnecessary includes
d8e8995
spiff remove unnecessary includes 120cee8
spiff changed: move function implementation to avoid include d32b7a4
spiff remove unnecessary include f96a36d
@wsoltys wsoltys [WIN32] fixed compilation after f96a36d ed1a6aa
@Memphiz Memphiz [xrandr] - handle _X_NORETURN the right way - thx for the hint @NHell… aca862c
@jmarshallnz jmarshallnz Merge pull request #1121 from Karlson2k/Fix-NfoUrl
[NfoFile] Fix for nfofile with URL
eb76c09
@jmarshallnz jmarshallnz Merge pull request #1143 from bossanova808/master
[Fix] For inconsistent 'play from here' context menu behaviour....
a85cf75
@jmarshallnz jmarshallnz Merge pull request #1129 from jmarshallnz/remove_smb_auth_details_in_…
…add_source

Remove smb auth details in add source
cc57404
@jmarshallnz jmarshallnz Merge pull request #1128 from jmarshallnz/separate_db_update
Separate db update from CDatabase::Open()
d9ca8ee
Jonathan Marshall [seekbar] adds seek handler rather than handling seeking directly in …
…CGUIDialogSeekBar.
124b538
Commits on Jul 12, 2012
Jonathan Marshall Move the seek handling to the app. Fixes problems where analog seekin…
…g didn't respond while the seekbar wasn't allowed on screen. Fixes #11712
c1398f4
@jmarshallnz jmarshallnz Merge pull request #1134 from jmarshallnz/seek_handler
Handle "analog" seeking in a separate handler rather than in GUIDialogSeekBar
252ed09
Fneufneu [FreeBSD] add missing inttypes.h include
fix build of EndianSwap.cpp
20e5ee5
@Montellese Montellese videodb: fix retrieval of total number of items in GetFooByWhere() aa67151
@Montellese Montellese smartplaylist: fix album/song-based smartplaylists after ae9ed89 515caed
@wsoltys wsoltys fixed: regression of 6010dde 13cc171
@wsoltys wsoltys [WIN32] fixed wrong vs buildlog location and type the vs buildlog to …
…the console to see it on the winbilly page
beca128
@wsoltys wsoltys [WIN32] fixed regression of 5c575d8 197b43b
spiff changed: remove CShortcut class and related code
this is a useless xbox remnant that won't ever be used elsewhere
c7fc25a
spiff changed: drop CProgramDatabase
unused and unusable in its current state
92f0eae
spiff changed: prune unnecessary includes and unused code from CGUIWindowPr…
…ograms
d206651
spiff changed: remove unused Cssrc class f13495d
Commits on Jul 13, 2012
@wsoltys wsoltys fixed regression of f13495d. On windows M_PI is defined in math.h (us…
…ing _USE_MATH_DEFINES). As I don't know if this is valid for the other ports I just use the define here.
2946521
vdrfan changed: remove an unused variable d8bdf1c
@wsoltys wsoltys changed: use math.h instead of hardcoded M_PI. Latter one should be a…
…vailable on all platforms.
5f048bf
bobo1on1 fixed: compile with --disable-joystick 69d3836
bobo1on1 fixed: m_Joysticks in HALManager.h has nothing to do with eventserver 44ab761
Jonathan Marshall fix issue with missing tags causing empty artist/album artist/genre caf9ba1
Commits on Jul 14, 2012
@wsoltys wsoltys changed: guard define with ifndef to avoid possible compiler warnings 879e497
@koying koying FIX : dateAdded wrong for curl based filesystem 2720056
Arne Morten Kvarving Merge pull request #1159 from koying/master
FIX : dateAdded wrong for curl based filesystem
a1725e8
@DDDamian DDDamian [PAPlayer] Fix locking issues when Application.cpp and GUIInfoManager…
….cpp require data. Much better performance now - no more hammering stream locks. Also fixes bad sleep logic where it slept less when buffer was more full lol
6caf4b0
@DDDamian DDDamian [AE] Fix cutoff of last file played when crossfading 8781be4
@Memphiz Memphiz Revert "Enable the ao_set_metadata* functions if available from libsh…
…airport." - it simply doesn't work that way and breaks that feature

This reverts commit 537bec4.
f58b70a
Arne Morten Kvarving Merge pull request #1160 from cptspiff/pap
[PAPlayer] Fix locking issues
8909327
Arne Morten Kvarving Merge pull request #1119 from otzy007/ticket13098
fix for bug #13098: Do not show PAUSE while skipping a paused track
d4e069b
Commits on Jul 15, 2012
Arne Morten Kvarving Merge pull request #1042 from eriklundberg/master
Bug when cleaning the database from rar files
46ec1b4
@chadoe chadoe [WIN32] fixed: older versions of libcdio dll were not uninstalled. 19c45f3
@Montellese Montellese jsonrpc: fix typo in JSON schema description 43a7772
arnova fixed: Compile warning cbd834b
arnova fixed: Formatting 9c8d39b
@DDDamian DDDamian [VIZ] Milkdrop expects 576 samples unlike all the others - converted …
…to work on 512 samples supplied - looks prettier
d2dd93c
@DDDamian DDDamian [AE] Fix inverted "Boost levels on downmix" naming and usage. 3063422
@Memphiz Memphiz Merge pull request #1162 from Memphiz/aefix1
[VIZ] Milkdrop expects 576 samples unlike all the others - converted to ...
80b9472
@Memphiz Memphiz Merge pull request #1163 from Memphiz/aefix2
[AE] Fix inverted "Boost levels on downmix" naming and usage.
22659f5
spiff fixed: return kHz, no Hz 678ccd1
Arne Morten Kvarving Merge pull request #1165 from cptspiff/sr
fixed: return kHz, no Hz
f9f7c37
Commits on Jul 16, 2012
@Montellese Montellese jsonrpc: add "value" property to Input.OnInputRequested notification 1af4a02
@orewagundam orewagundam Changed CGUIViewStateVideoTVShows constructor
Replace current sort methods with the same ones used in
CGUIViewStateVideoMovies class. Used by smart playlists for sorting
operations.

Changed the constructor

Fixed constants in constructor.

As suggested, fixed the constants used in AddSortMethod(). Bad
copy-paste from the movies class constructor. It's strange that it
worked even like that (tried for example to sort by date).
ea3733e
@Montellese Montellese Merge pull request #1158 from orewagundam/master
Fixed sorting for tvshows smart playlists.
92564dc
Commits on Jul 17, 2012
@koying koying FIX: JSON-RPC: Setting the playcount does not produce expected announ…
…cement
d7d9610
@Montellese Montellese Merge pull request #1172 from koying/json-fix
FIX: JSON-RPC: Setting the playcount does not produce expected announcement
a6a5de0
@Memphiz Memphiz [AE/CA/IOS] - fixed initialisation order in c'tor ddf7f13
@Memphiz Memphiz [AE/CA] - fix possible assert which is non fatal 2921591
@elupus elupus [darwin] name threads so they are visible in debugger b4c6016
Commits on Jul 18, 2012
@midripps midripps Fix for thumbs not auto-generating for some iPhone MOVs. c01cae1
@Karlson2k Karlson2k CPUInfo.cpp cosmetic and cleanup 290b3af
@Karlson2k Karlson2k Prevent using uninitialized variables on Win32 6ba8a03
@Karlson2k Karlson2k Return lastUsedPercentage instead of 0 when current percentage is unk…
…nown
5352991
@Karlson2k Karlson2k Update lastReadTime only when CPU usage reading was really successful 3e0215a
arnova fixed: Typo in 2921591 5425f5d
@Karlson2k Karlson2k Update CPU usage twice per second instead of one time in 2 seconds ae9198e
@Memphiz Memphiz Merge pull request #1178 from midripps/master
Fix for thumbs not extracting for some iPhone MOVs.
2045147
Mike Fix potential buffer overflow using karaoke. c34f35b
@Memphiz Memphiz Merge pull request #1180 from jabbera/CKaraokeLyricsCDG-buff-overflow
Fix potential buffer overflow using karaoke.
6d6af6b
@garbear garbear Fixed: g_graphicsContext used a reference to itself fbb95f4
Commits on Jul 19, 2012
Mike Uninitialized variable. This could cause an issue, but is extremely u…
…nlikely.
7503521
Mike match new[] with delete[] instead of delete a65da10
Mike Match data type of member variable. 2b69b92
@jmarshallnz jmarshallnz Merge pull request #1186 from jabbera/GeneralCleanup
A few more issues found from Code Analysis in VS
9701022
@Memphiz Memphiz [cosmetic] - remove unneeded var d4be855
@jmarshallnz jmarshallnz Merge pull request #1173 from Karlson2k/CPUInfo_small_fix1
Prevent using of uninitialized variable, some cosmetic in CPUInfo.cpp
26a359c
@Karlson2k Karlson2k Fix include path in CPUInfo.h d2ba569
@jmarshallnz jmarshallnz Merge pull request #1188 from Karlson2k/CPUInfo_small_fix2
Fix include path in CPUInfo.h
2ceb4bf
Commits on Jul 20, 2012
vdrfan cosmetics: indentation fc053f2
vdrfan fixed: do not try to extract stream details for stub files (closes #1…
…3194)
d92792f
Commits on Jul 21, 2012
@anssih anssih fixed: do not wrongly hide some ALSA HDMI devices
Currently the AESinkALSA code takes empty but existing ELD data to
always mean that the HDMI port is unconnected and hides it.

However, many HDA HDMI output devices do not properly pass ELD data,
leaving the reported ELD empty.

Therefore, only hide unconnected ports for HDA Intel and HDA NVidia,
since ELD seems to be reliable with those cards/drivers (i.e. if it
exists, it is populated, and if it is not supported, it does not exist).
c7015ec
@anssih anssih fixed: build with libshairport without ao_set_metadata
Fix build with libshairport without the
AudioOutput.ao_set_metadata and AudioOutput.ao_set_metadata_coverart
members (which were added to libshairport git two months ago).

A previous commit 537bec4 had already tried to do this, but it did not
work properly and was therefore reverted in f58b70a.
3cc6144
@Memphiz Memphiz Merge pull request #1190 from anssih/fix/shairport-metadata-check
fixed: build with libshairport without ao_set_metadata
ea2f5f8
@anssih anssih [AE] fixed: DTS HD core-only passthrough regression
Commit 941eae2 ("[AE] fixed: passthrough of LE DTS, pre-padded DTS,
invalid DTS") broke DTS-HD core-only passthrough.

Fix it.
8e94e27
@anssih anssih Make CAESinkALSA::GetParamFromName return string directly
Suggested by elupus to make the code more clear.
7ad9c1b
@anssih anssih AESinkALSA: Factor guessing AEDeviceType to a separate function 139b521
@anssih anssih fixed: consider "spdif" ALSA devices as S/PDIF
"spdif" ALSA device is an alias for "iec958", though reportedly it may
be exposed via ALSA hints on some systems.

Consider it as S/PDIF as suggested by elupus.
7d928ac
@wsoltys wsoltys [WIN32] fixed: enable system screensaver when loosing focus (closes #…
…13180)
a6ca119
@wsoltys wsoltys Revert "[WIN32] fixed: enable system screensaver when loosing focus (…
…closes #13180)"

This reverts commit a6ca119.

Think before implement!
97c8ba5
Commits on Jul 22, 2012
Jonathan Marshall fix addon settings dialog not resetting correctly on unload f4d87e3
@anssih anssih fixed: ineffective ALSA HDMI device whitelist check
The check added in c7015ec was ineffective, as noted by FernetMenta
(some " == 0" checks went missing after the previous working version of
the patch).

Fix it.
fa81a76
spiff fixed: add missing dependency generation rules to json-rpc / http-api…
… Makefiles
58abd46
spiff remove unnecessary includes d074c5a
@zewt zewt Fix reads from Transfer-Encoding: chunked servers.
There's no Content-Length in this mode, so GetLength() returns 0.
ad4ad22
@classicspam classicspam Bugfix: AudioEngine would get stuck in Drain state if memcachebuffer …
…reached 0. It would cause the video to be stuck at 4-6 FPS and would not fix itself (even if buffer started getting filled) until video was stopped and restarted.
9e58405
Arne Morten Kvarving Merge pull request #1201 from classicspam/Branch_AudioEngineBugFix
AudioEngine BugFix
9ee43a0
spiff changed: make CApplicationMessenger a singleton instead of a CApplict…
…ion member

- more in line with other code
- simpler syntax
- helps minimize the taint of Application.h all over
c72b93c
Arne Morten Kvarving Merge pull request #1198 from cptspiff/lessdeps
Clean up build dependencies by removing unnecessary includes
fb31528
@zewt zewt Disable the Windows screensaver normally.
This is the ordinary way applications disable screensavers.  This keeps
XBMC from leaving the screensaver disabled when it doesn't have focus,
which is very important on plasma TVs, and this way is also much simpler.
1d65612
Commits on Jul 23, 2012
@wsoltys wsoltys Merge pull request #1183 from zewt/windows-screensaver-on-focus
[WIN32] Fix the Windows screensaver left disabled when XBMC loses focus.
f7f77a7
@classicspam classicspam Music Scanner Bugfix
1. Bugfix: Music scanner did not correctly load the image artwork for directories with more than 1 album (i.e. "Singles" directories).  Now it does.
d5e295c
@FernetMenta FernetMenta dirty regions: dont add invalidated, invisible controls to the tracker 1a2612b
@Montellese Montellese smartplaylist: fix typo in artist rule for albums 7835fdc
@night199uk night199uk [musicscanner] Fix a deadlock for users with NFO_COMBINED or NFO_URL …
…in their artist or album directories.
9936f91
Commits on Jul 24, 2012
@anssih anssih fixed: too many ALSA audio devices enumerated on Ubuntu
Ubuntu has patched their alsa-lib so that "defaults.namehint.extended"
defaults to "on" instead of upstream "off", causing lots of unwanted
extra devices (many of which are not actually routed properly, like the
"dmix:$foo" ones which may actually direct to a completely different
device) to be found by the enumeration process.

Skip such devices.
083a6c8
@anssih anssih fixed: do not replace ALSA card name with device name as last resort
If multiple enumerated ALSA devices share the same card id and logical
device number, currently the card name is replaced with the raw device
name.

Instead of replacing the card name, append the raw device name to the
displayName.

Note that these kind of devices are not normally encountered.
6dd20c0
@opdenkamp opdenkamp cec: wake the screensaver when XBMC was made the active source. 5cea3da
@Memphiz Memphiz [cosmetic] - remove whitespaces 1431660
@davilla davilla fixed, do not assume videoplayer.synctype is valid without first chec…
…king videoplayer.usedisplayasclock
eb75f20
spiff changed: minimize URL.h header pollution 52e4d3b
spiff changed: minimize IFile.h header pollution 7c247ca
spiff changed: minimize Temperature.h header pollution 68fa2f2
spiff changed: minimize LangInfo.h header pollution df79418
spiff changed: minimize GUIInfoManager.h header pollution 1c5ef93
spiff changed: remove unnecessary includes f71ab09
Arne Morten Kvarving Merge pull request #1210 from cptspiff/lessdeps
lessen interdependencies - more of this crap
c308ce2
@wsoltys wsoltys cosmetics: fixed some warnings 4542cb5
Commits on Jul 25, 2012
@garbear garbear Cosmetic: Fixed typo being placed in log 2dec23b
@garbear garbear Cosmetic: Fixed typo being placed in debug log 6a2430b
@garbear garbear Fixed: g_windowManager used a reference to itself
c/p artifact from 6e1a053 by he who shall remain nameless ;-)
8d978da
@jmarshallnz jmarshallnz Merge pull request #1205 from classicspam/Branch_MusicScannerBugFix
Music Scanner Bugfix
cb6496e
Voyager-xbmc fix watched-unwatched for TV shows and episodes 392cef8
@jmarshallnz jmarshallnz Merge pull request #1176 from Voyager-xbmc/fix-watched-unwatched-tvshows
Fix watched-unwatched for TV shows and Seasons
82b31e5
Commits on Jul 26, 2012
@Memphiz Memphiz [fix] - workaround for swscale crashing on images which have an uneve…
…n number of pixels in width
88d6eed
@wsoltys wsoltys [WIN32] fixed: don't call SetSetting if we don't have a valid g_plugi…
…n. This shouldn't happened but it seems to be for some setups so at least don't crash.
d32d809
@wsoltys wsoltys [WIN32] fixed: obey the return codes. 0f01b65
Commits on Jul 27, 2012
vdrfan cosmetic: removed superfluous dialog includes 32f79f8
@Montellese Montellese CVideoInfoTag: add tags in ToSortable() dfac77e
@Montellese Montellese fix sorting of special episodes (fixes #13166) 07ae1d6
@pieh pieh use shared_ptr to track last focused item in containers 566dc10
@pieh pieh reset static items only if item changes visibility
decreases cpu load with wraplists (they're not deleting/recreating extra items each frame)
eaed915
@pieh pieh update scrollbar if any static item has changed 6428682
@pieh pieh guilib: if currently focused control can no longer be focused, fallba…
…ck to default control

fixes #13117
274cb40
@pieh pieh try lookup first in CGUIControlGroup::GetFocusedControl() 83ff758
@pieh pieh small optim in CGUIControlGroup::GetFocusedControl() to avoid double …
…control group tree traversing
f472ae7
@wsoltys wsoltys [WIN32] fixed: it shouldn't happen but according to some crash dumps …
…varName doesn't contain a WAVEFORMATEX even though the return status is S_OK.
9ff141a
@Memphiz Memphiz [ios] - learn something from android 1. eat all events with each mess…
…agepump.

2. use a double-buffered queue to avoid excess locking.
0ba76a0
@pieh pieh Merge pull request #791 from pieh/wraplist_focus_animation 25aff62
@pieh pieh password manager: don't save/store authenticated url if it doesn't co…
…ntain username
564def5
Commits on Jul 28, 2012
vdrfan changed: GUIBaseContainer.h include is no longer needed for VIEW_TYPE_* 8f7f0c3
@Montellese Montellese [cosmetic] CSoftAEStream: fix multiple "convertion from foo to bar, p…
…ossible loss of data" warnings
bd32fc0
@Montellese Montellese [cosmetic] mysqldataset: fix "'ARRAYSIZE': macro redefinition" warning 46de682
@Montellese Montellese [cosmetic] udf25: fix "unary minus operator applied to unsigned type,…
… result still unsigned" warning
119da7c
@Montellese Montellese [cosmetic] CDVDMessageQueue: fix "conversion from 'counst double' to …
…'int', possible loss of data" warning
14834ab
@Montellese Montellese [cosmetic] yuv2rgbshader: fix "truncation from 'double' to 'float'^" …
…warnings
d9adba7
@Montellese Montellese [cosmetic] CDVDAudioCodecPassthroughFFmpeg: fix "switch statement con…
…tains 'default' but no 'case' labels" warnings
8702387
@Montellese Montellese Merge pull request #1223 from Montellese/warnings_must_die
[win32] fix some warnings
fa070fe
vdrfan fixed: empty context menu entry on livetv items 156f826
vdrfan cosmetics: indentation 8105a41
@Memphiz Memphiz [osx] - adapt readme for building with osx mountain lion aaa960f
@Memphiz Memphiz [osx/ios/atv2] - fix xcode projects 1547f0b
@Memphiz Memphiz [linux] - fixed compilation for cptspiff 59d5142
@garbear garbear Fixed: xbmc.sh.in expects a return code of 65 if XBMC.RestartApp is c…
…alled.

Fixes #13209
15a507f
Commits on Jul 29, 2012
@wsoltys wsoltys [WIN32] changed: DeviceIoControl needs only a data buffer of 8 bytes …
…for this type of request. Zero the memory and log if the call fails. Reduce the timeout from 30 minutes to 2 seconds :)
2774f6b
@pieh pieh Merge pull request #1179 from pieh/no_longer_focusable 1b0360e
Commits on Jul 30, 2012
@FernetMenta FernetMenta Merge pull request #1168 from FernetMenta/drfix
dirty regions: dont add invisible controls to the tracker
e15269b
Commits on Jul 31, 2012
@opdenkamp opdenkamp cec: optionally pause playback when switching to another source, and …
…resume playback when switching back to XBMC
bcef616
@opdenkamp opdenkamp cec: map the data (teletext) button to XINPUT_IR_REMOTE_TELETEXT and …
…subpicture to XINPUT_IR_REMOTE_SUBTITLE
cedf37a
@Memphiz Memphiz [ios/tvout] - switch off overscan compensation which was introduced i…
…n iOS5.0 by apple. Also cosmetics (sorry theys are done automagically with my Xcode plugin)
c79d1ef
@Memphiz Memphiz [cosmetics] - fix whitespaces 12257fb
@Memphiz Memphiz [AE/CA] - null pointers after deleting - yes we are pedantic here 11652c5
@Memphiz Memphiz [AE/CA] - cosmetics - davilla told me if i do it that way i might end…
… up beeing perfect. :D
9386cc7
@Memphiz Memphiz Merge pull request #1181 from Memphiz/swscalecrash
Workaround for swscale crashing on pictures with odd number of pixels in width (spotted on ios and osx)
6e2ddbd
Cory Fields build: fix cmyth build after 2d79579. d04e05e
@garbear garbear Fixed crash of death when calling XBPyThread::stop() while inside a p…
…ython dialog's doModal()

When XBPyThread::stop() is called, a SystemExit exception is raised in Python script's threads, but the Python window "misses the memo". It continues calling PyXBMC_MakePendingCalls() ([1]), which XBMC continues populating with onAction events even though the event's thread has a SystemExit exception raised.

Eventually, as python objects are unloaded, the user-supplied onAction() will throw an exception. When this is caught ([2]), a call to PyErr_Print() seems to go on an object-freeing spree, but the deallocation of something naughty causes python26.dll (Win32) to invoke a "crash of death" immediately terminating the entire XBMC application.

The fix is to have doModal() check if the exception has been raised; if so, hide the window and return control to the python script. By having XBPyThread::stop() invoke g_pythonParser.PulseGlobalEvent() we can force doModal() to wake up immediately instead of laying dormant until another onAction event.

[1] https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/python/xbmcmodule/window.cpp#L540
[2] https://github.com/xbmc/xbmc/blob/master/xbmc/interfaces/python/xbmcmodule/GUIPythonWindow.cpp#L281
469b420
Commits on Aug 01, 2012
@davilla davilla [osx] check for RES_INVALID before we use it as an array index 66d6fc3
@davilla davilla [osx/ios] fixed compiler warnings, move -Wreorder to WARNING_CFLAGS t…
…o OTHER_CPLUSPLUSFLAGS, it is a c++/objc compiler flag
2ceb5f8
@pieh pieh fix screen calibration window broken after 1b0360e
resize and mover control are used only there and we hide/show them in CGUIWindowSettingsScreenCalibration::DoProcess which will cause false-positive result in current control no longer focusable test
e4443f2
@Montellese Montellese release: bump versions for August merge window dea557c
@Montellese Montellese Merge pull request #1167 from Montellese/jsonrpc_oninputrequested
jsonrpc: add "value" property to Input.OnInputRequested notification
9dfc424
@mad-max mad-max added abiltity to look up folder names for music videos 701eac7
@opdenkamp opdenkamp Merge pull request #1211 from Pulse-Eight/cecwakescreensaver
cec: wake the screensaver when XBMC was made the active source.
22e12a7
@mkortstiege mkortstiege Merge pull request #852 from mad-max/lookupfoldernames
added ability to use folder names for music video lookup
00ecb8f