Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose isFileDoesNotExist and improve CI tests #657

Merged
merged 3 commits into from
Mar 2, 2020

Conversation

LoicPoullain
Copy link
Member

Issue

  • isFileDoesNotExist is not exported in @foal/storage.
  • lerna run test is a bit slow and, when a test fails in Github Actions, it is difficult to know which one it is.

Solution and steps

  • Export isFileDoesNotExist
  • Do not use lerna run test in Github Actions

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Mar 2, 2020
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #657 into v1-7-0 will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-7-0     #657      +/-   ##
==========================================
+ Coverage   99.37%   99.62%   +0.25%     
==========================================
  Files          67       90      +23     
  Lines        1114     1591     +477     
  Branches      269      337      +68     
==========================================
+ Hits         1107     1585     +478     
+ Misses          7        6       -1     
Impacted Files Coverage Δ
packages/core/src/core/routes/utils.ts 100.00% <0.00%> (ø) ⬆️
packages/core/src/express/not-found.ts 100.00% <0.00%> (ø) ⬆️
packages/core/src/express/create-app.ts 100.00% <0.00%> (ø) ⬆️
packages/core/src/sessions/constants.ts 100.00% <0.00%> (ø) ⬆️
packages/core/src/express/send-response.ts 100.00% <0.00%> (ø) ⬆️
packages/core/src/core/http/http-methods.ts 100.00% <0.00%> (ø) ⬆️
packages/core/src/common/utils/escape-prop.ts 100.00% <0.00%> (ø) ⬆️
packages/core/src/common/utils/render.util.ts 100.00% <0.00%> (ø) ⬆️
packages/core/src/openapi/utils/merge-tags.ts 100.00% <0.00%> (ø) ⬆️
packages/core/src/common/utils/validate.util.ts 100.00% <0.00%> (ø) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da21c0...b34bf43. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 9b52b74 into v1-7-0 Mar 2, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Mar 2, 2020
@LoicPoullain LoicPoullain deleted the is-file-does-not-exist branch March 2, 2020 14:48
@LoicPoullain LoicPoullain mentioned this pull request Mar 2, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant