Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service initialization (boot method) #678

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Apr 23, 2020

Issue

Resolves #628

Solution and steps

  • Add ServiceManager.boot (no parameters) to init all services with a boot method.
  • Allow to optionally boot services injected manually.
  • Add an optional parameter to ServiceManager.boot to init only one specific service.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation Apr 23, 2020
@LoicPoullain LoicPoullain mentioned this pull request Apr 23, 2020
7 tasks
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #678 into v1-8-0 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           v1-8-0     #678   +/-   ##
=======================================
  Coverage   99.64%   99.65%           
=======================================
  Files          94       94           
  Lines        1700     1715   +15     
  Branches      399      403    +4     
=======================================
+ Hits         1694     1709   +15     
  Misses          6        6           
Impacted Files Coverage Δ
packages/core/src/core/service-manager.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3eaef...4cc0468. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 478665f into v1-8-0 Apr 29, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release Apr 29, 2020
@LoicPoullain LoicPoullain deleted the boot-methods branch April 29, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

None yet

1 participant