Extend ValidateBody from typestack #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to provide "factory function" for cls against which body will be validated.
AleksandrSl
commented
Jul 9, 2020
| deepStrictEqual(actual2.body, { | ||
| message: 'The request body should be a valid JSON object or array.' | ||
| }); | ||
| context('given class as argument', () => { |
There was a problem hiding this comment.
Actually, I didn't change the tests, just generalized them a little bit to run same tests in separate context (to avoid duplication)
AleksandrSl
commented
Jul 9, 2020
| cls: Class | ((controller: any) => Class), | ||
| options: ValidateBodyOptions = {} | ||
| ): HookDecorator { | ||
| return Hook(async function(this: any, ctx) { |
There was a problem hiding this comment.
Changed to function cause I want proper this from the call site
|
Seems that failed test isn't connected to changes |
LoicPoullain
approved these changes
Jul 16, 2020
| deepStrictEqual(actual2.body, { | ||
| message: 'The request body should be a valid JSON object or array.' | ||
| }); | ||
| context('given class as argument', () => { |
5 tasks
Issue tracking
automation
moved this from Work In Progress
to Done / Closed This Release
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to provide "factory function" for clas against which body will be validated.
Issue
#752
Solution and steps
It turned out to be a little bit harder and flaky than ValidateBody from core. There is no robust difference between function and class (it's just a constructor function). The only way I found, use only arrow functions in this decorator if you want it to be generic, cause they cannot be used as constructors and don't have
prototype. (https://stackoverflow.com/a/45759444/6540091).Maybe it's worth adding separate decorator for this case, though I didn't came up with meaningfull name for it.
P.S. I didn't update the docs, cause I'm not sure of the solution.
Checklist