fix(SwaggerValidation): Allow hierarchy in paths #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regex used to test for duplicate paths uses greedy matching causing valid RESTful hierarchy to be flagged as an error: fix FoalTS#821
jeredmasters
force-pushed
the
fix-swagger-validation
branch
from
db841c2
to
cac7f64
Compare
|
I am unable to view the |
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
- Coverage 99.62% 99.60% -0.02%
==========================================
Files 90 94 +4
Lines 1589 1766 +177
Branches 335 425 +90
==========================================
+ Hits 1583 1759 +176
- Misses 6 7 +1
Continue to review full report at Codecov.
|
LoicPoullain
approved these changes
Nov 11, 2020
| }); | ||
| throw new Error('Expected an exception here'); | ||
| } catch (err) { | ||
| notStrictEqual(err.message, 'Expected an exception here'); |
There was a problem hiding this comment.
I added this line here. Otherwise the test was always successful because all errors (thrown in line 40 or line 44) were caught.
There was a problem hiding this comment.
ah true, thanks
Issue tracking
automation
moved this from Work In Progress
to Done / Closed This Release
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex used to test for duplicate paths uses greedy matching causing valid RESTful hierarchy to be
flagged as an error:
fix #821