-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SwaggerValidation): Allow hierarchy in paths #822
fix(SwaggerValidation): Allow hierarchy in paths #822
Conversation
Regex used to test for duplicate paths uses greedy matching causing valid RESTful hierarchy to be flagged as an error: fix FoalTS#821
db841c2
to
cac7f64
Compare
I am unable to view the |
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
- Coverage 99.62% 99.60% -0.02%
==========================================
Files 90 94 +4
Lines 1589 1766 +177
Branches 335 425 +90
==========================================
+ Hits 1583 1759 +176
- Misses 6 7 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
}); | ||
throw new Error('Expected an exception here'); | ||
} catch (err) { | ||
notStrictEqual(err.message, 'Expected an exception here'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this line here. Otherwise the test was always successful because all errors (thrown in line 40 or line 44) were caught.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah true, thanks
Regex used to test for duplicate paths uses greedy matching causing valid RESTful hierarchy to be
flagged as an error:
fix #821