New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LumenServiceProvider::getRouter() #190

Merged
merged 1 commit into from Sep 9, 2017

Conversation

Projects
None yet
2 participants
@passcod
Copy link
Contributor

passcod commented Sep 9, 2017

Otherwise calling php artisan dies with:

[Symfony\Component\Debug\Exception\FatalThrowableError]
Call to undefined method Laravel\Lumen\Application::group()

Versions:

  • PHP 7.1.9
  • Lumen 5.5.0
  • folklore/graphql 1.0.25
Fix LumenServiceProvider::getRouter()
Otherwise calling `php artisan` dies with:

```
[Symfony\Component\Debug\Exception\FatalThrowableError]
Call to undefined method Laravel\Lumen\Application::group()
```

Versions:

- PHP 7.1.9
- Lumen 5.5.0
- folklore/graphql 1.0.25
@dmongeau

This comment has been minimized.

Copy link
Member

dmongeau commented Sep 9, 2017

Actually this works only in Lumen 5.5. The router doesn't exists in previous version, we would have to remove completely the ->group call I guess

@dmongeau

This comment has been minimized.

Copy link
Member

dmongeau commented Sep 9, 2017

Oh sorry, my mistake, the ->group method does exists in previous version of lumen. It's only in 5.5 that you have to use app->router. I will had a check if ->router exists in your pull request

@dmongeau dmongeau merged commit c3c44b4 into Folkloreatelier:master Sep 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@passcod passcod deleted the passcod:patch-1 branch Sep 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment