New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit run fix #96

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Projects
None yet
5 participants
@neronmoon
Contributor

neronmoon commented Mar 9, 2017

Fixes #81
registerGraphQL was called twice for some reason. So fast fix it

@neronmoon neronmoon changed the title from Fixes #81 to PHPUnit run fix Mar 9, 2017

// Check if facades are activated
if (Facade::getFacadeApplication() == $this->app) {
if (Facade::getFacadeApplication() == $this->app && !$registred) {

This comment has been minimized.

@neoascetic

neoascetic Mar 9, 2017

Maybe class_exists would be a better solution for this

@neoascetic

neoascetic Mar 9, 2017

Maybe class_exists would be a better solution for this

This comment has been minimized.

@neronmoon

neronmoon Mar 10, 2017

Contributor

It's not. Because class exists even its not aliased, Pavel

@neronmoon

neronmoon Mar 10, 2017

Contributor

It's not. Because class exists even its not aliased, Pavel

@knieber

This comment has been minimized.

Show comment
Hide comment
@knieber

knieber Apr 20, 2017

We're also running into this issue and can confirm this PR fixes #81. Please merge this.

knieber commented Apr 20, 2017

We're also running into this issue and can confirm this PR fixes #81. Please merge this.

@weklund

This comment has been minimized.

Show comment
Hide comment
@weklund

weklund Apr 20, 2017

I could really use this PR, I can't do CI/CD without it. Would hate to fork. @dmongeau @phatshambler

weklund commented Apr 20, 2017

I could really use this PR, I can't do CI/CD without it. Would hate to fork. @dmongeau @phatshambler

@dmongeau dmongeau merged commit dfdaf0e into Folkloreatelier:master Apr 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dmongeau

This comment has been minimized.

Show comment
Hide comment
@dmongeau

dmongeau Apr 21, 2017

Member

Merged, thanks a lot! Tagged as v1.0.11

Member

dmongeau commented Apr 21, 2017

Merged, thanks a lot! Tagged as v1.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment