Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multi-core fuzzer #348

Merged
merged 6 commits into from May 17, 2021
Merged

Implement multi-core fuzzer #348

merged 6 commits into from May 17, 2021

Conversation

devatwork
Copy link
Contributor

Refactor the fuzzer implementation into the engine and the
corpus_based_fuzzer components. This allowes multiple fuzzers
to co-exist side-by-side.

The engine is overhauled to support running on multiple core in
parallel. Big shoutout to @mvanbutselaar for his help with the
implementation. The output of the engine is colorized for improved
readability.

Refactor the fuzzer implementation into the engine and the
corpus_based_fuzzer components. This allowes multiple fuzzers
to co-exist side-by-side.

The engine is overhauled to support running on multiple core in
parallel. Big shoutout to @mvanbutselaar for his help with the
implementation. The output of the engine is colorized for improved
readability.
@DrRataplan
Copy link
Member

BundleMon

Unchanged files (2)
Status Path Size Limits
fontoxpath.esm.js
88.68KB -
fontoxpath.js
88.58KB -

No change in files bundle size

Final result: ✅


Current branch size history | Target branch size history

@coveralls
Copy link

coveralls commented May 15, 2021

Coverage Status

Coverage remained the same at 95.707% when pulling 67c1780 on threaded-fuzzer into 6d52b43 on master.

@devatwork
Copy link
Contributor Author

@DrRataplan Not sure how to deal with the 2 remaining CodeFactor issues. @mvanbutselaar and I needed to alias the Worker class to ThreadWorker, so in my opinion both the casing is correct (because it is a type alias for a class) and the use of the spread operator for the aliasing. Any suggestions?

@DrRataplan
Copy link
Member

DrRataplan commented May 17, 2021

I guess a big part of why the code is not deemed up-to-par is because of the mixed import and require. Using more import as should make this better. Did you already try that?

My linter immediately warned me about the mixed imports/require. Consider making tslint work, it helps in the long run. I'll push a fix

package-lock.json Outdated Show resolved Hide resolved
@devatwork
Copy link
Contributor Author

Thanks, my linter is seriously fubar and my TS skills are not up to par yet. Thanks for making the changes and maybe at some point we can jointly fix my linter because these issues waist both our time.

@devatwork devatwork requested a review from DrRataplan May 17, 2021 10:15
fuzzers/engine.ts Outdated Show resolved Hide resolved
@devatwork devatwork merged commit 0e325de into master May 17, 2021
@devatwork devatwork deleted the threaded-fuzzer branch May 17, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants