Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Remove KireiCake? #1608

Open
Thermospore opened this issue Apr 10, 2021 · 12 comments
Open

Remove KireiCake? #1608

Thermospore opened this issue Apr 10, 2021 · 12 comments

Comments

@Thermospore
Copy link
Contributor

I'm not sure the version currently on the yomichan info page serves much use

  1. it mostly consists of an old copy of jmdict
  2. the non-jmdict entries are of very low quality

To see the entries that didn't come from jmdict, look at the upper table here: https://kireicake.com/rikaicake-online/

I get the impression the creator made many of these entries on the spot when seeing the word for the first time

A given entry usually has a handful of these qualities:

  1. straight up wrong
  2. not entirely wrong, but not particularly accurate
  3. very incomplete
  4. has typos / formatting errors / inconsistencies
  5. vastly inferior to the jmdict entry
  6. vastly inferior to the jj entries
  7. very apparent / unneeded A+B

some entries off the top of my head
image
image
image
image
image
image
image

I think if it were to be kept on the yomichan page, the old jmdict entries should be removed at least. Here are builds I made from the original tables. I did my best to fix the formatting errors / inconsistencies. Beware if you want to make your own builds, as the upper table is particularly convoluted and inconsistent

RikaiCake [upper table] v1.zip
RikaiCake [lower table] v4.zip

I mean no offense to the creator, they obviously provide the tables in good will. But in general, even if it has something not in any of your other dictionaries you are probably better off googling it yourself

@FooSoft
Copy link
Owner

FooSoft commented Apr 12, 2021

@Thermospore very good work. Do you mind if I put these on the download page instead of the old version that's there? I completely agree that the current KireiCake dictionary is a huge mess, and this looks to be a solid improvement.

@Thermospore
Copy link
Contributor Author

@FooSoft Sure, you are welcome to use them. @toasted-nutbread might want to take a look at them first though to see if there are any changes they'd like

Each dictionary's metadata includes a link to the google sheet I used to build it, which might be useful for the upper table in particular if you want to make your own build

Also after giving it some thought, due to the low quality I'd prefer to have my name removed from the metadata

@archiif
Copy link
Contributor

archiif commented Apr 17, 2021

To see the entries that didn't come from jmdict, look at the upper table here

Isn't the upper table the old version which contains the old version of jmdict's entries?

@Thermospore
Copy link
Contributor Author

Isn't the upper table the old version which contains the old version of jmdict's entries?

No, KireiCake is unrelated. The upper table has the older entries and the lower table has the newer entries. At a glance there is a bit of overlap, but you can think of them as separate volumes.

I think the version of KireiCake on the Yomichan info page is actually an import of the Rikaichan dictionary, which is how the old JMdict entries got mixed in there? Haven't looked into it tbh

@FooSoft
Copy link
Owner

FooSoft commented Apr 18, 2021

That's exactly what it is.

@archiif
Copy link
Contributor

archiif commented Apr 21, 2021

I see, that makes sense.
Btw, can you provide some instructions on how to build the dictionary? Would be useful if you want to update it yourself.

@Thermospore
Copy link
Contributor Author

Thermospore commented Apr 21, 2021

@grospoulpe
Copy link

Seems KireiCake is still useful, because without enabling it in my list (JMdict (French), JMdict (English), 研究社 新和英大辞典 第5版, and JMnedict installed, too), やはり is not found. (found in Jisho.org, though: https://jisho.org/word/矢張り )
Sentences used (Japanese, The Manga Way, 247)
なぜ逃げる?やはりお前が犯人なんだな!!  うるせえ!!
Why do you run away? You really are the true killer, aren't you?!  Get lost!

@Thermospore
Copy link
Contributor Author

Maybe I'm not understanding, but やはり seems to be present in almost all of my dictionaries

And the KireiCake/RikaiCake entry is lackluster

image

some don't put the kanji in the headword
image

@grospoulpe
Copy link

Mmh, I don't have all that stuff.

Maybe something is wrong in my configuration, but I have all JP-EN dictionary downloadable from https://foosoft.net/projects/yomichan/

yomichan-settings-2021-05-23-20-32-51.zip

@toasted-nutbread
Copy link
Collaborator

やはり is present in term_bank_28.json of jmdict_english.zip, importing file and enabling the dictionaries worked for me. Perhaps your imported dictionaries are out of date and should be reimported? Not sure what the issue would be otherwise.

@grospoulpe
Copy link

Thanks, I downloaded that one from https://foosoft.net/projects/yomichan/, and noticed a size difference (it's bigger: 7,555KB vs 6766KB) from the one I downloaded in January 2021. So, I deleted the one installed, and imported the one I've just downloaded.
Now, the term is present.
Thanks again for your response. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants