Permalink
Commits on Jul 12, 2017
  1. Merge pull request #654 from Foodcritic/11.3

    Release 11.3
    tas50 committed on GitHub Jul 12, 2017
  2. Release 11.3

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 12, 2017
  3. Merge pull request #653 from Foodcritic/nodestate

    FC001 should not alert on node.run_state[:foo]
    tas50 committed on GitHub Jul 12, 2017
  4. Update regression test for windows

    This was the bug I was fixed false alarming.
    
    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 12, 2017
  5. FC001 should not alert on node.run_state[:foo]

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 12, 2017
Commits on Jul 9, 2017
  1. Merge pull request #650 from Foodcritic/ffi_yajl

    Switch from yajl-ruby to ffi-yajl
    tas50 committed on GitHub Jul 9, 2017
  2. Merge branch 'master' into ffi_yajl

    damacus committed on GitHub Jul 9, 2017
  3. Make sure we still error properly on bad JSON data

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 9, 2017
  4. Merge pull request #649 from Foodcritic/fc033

    Minor FC033 cleanup with comments
    tas50 committed on GitHub Jul 9, 2017
  5. Merge branch 'master' into fc033

    damacus committed on GitHub Jul 9, 2017
  6. Switch from yajl-ruby to ffi-yajl

    ffi-yajl is used by Chef already so this is one less requirement in ChefDK. yajl-ruby install size in macOS ChefDK is 3.8M
    
    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 9, 2017
Commits on Jul 8, 2017
  1. Remove the Chef 11 support in the check

    Also add a comment explaining how flawed this logic is
    
    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 8, 2017
  2. Make the alert name more obvious

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 8, 2017
  3. Add some comments to FC033 code

    It's chained which makes it hard to follow
    
    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 8, 2017
  4. Remove the Chef 11 FC033 test

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 8, 2017
Commits on Jul 7, 2017
  1. Merge pull request #648 from Foodcritic/chefstyle

    Chefstyle fixes
    tas50 committed on GitHub Jul 7, 2017
  2. Chefstyle fixes

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jul 7, 2017
  3. Fix the travis badge

    tas50 committed on GitHub Jul 7, 2017
Commits on Jun 12, 2017
  1. Merge pull request #644 from Foodcritic/old_metadata

    Convert more cucumber tests to rspec
    tas50 committed on GitHub Jun 12, 2017
  2. Merge branch 'master' into old_metadata

    damacus committed on GitHub Jun 12, 2017
  3. Merge pull request #645 from Foodcritic/11.2

    Release 11.2
    tas50 committed on GitHub Jun 12, 2017
  4. Release 11.2

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jun 12, 2017
Commits on Jun 9, 2017
  1. Update regression test data

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jun 9, 2017
  2. Convert more cucumber tests to rspec

    I realize this is entirely un-DRY. That's kinda the point. It makes is SUPER obvious what we're testing for vs. the tire fire that is mentally decoding cucumber regexes and helper string builders. The tests are a bit longer, but it's worth it.
    
    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed May 27, 2017
  3. Merge pull request #641 from coderanger/no-opensource-by-default

    Don’t run the open source tag by default
    tas50 committed on GitHub Jun 9, 2017
Commits on Jun 8, 2017
  1. Merge pull request #634 from amalucelli/feature/dockerfile

    Docker to Foodcritic
    tas50 committed on GitHub Jun 8, 2017
  2. Merge pull request #643 from Foodcritic/new_metadata

    Add 13.1.31 metadata and make it the default
    tas50 committed on GitHub Jun 8, 2017
  3. Add 13.1.31 metadata and make it the default

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed Jun 8, 2017
Commits on Jun 7, 2017
  1. Changelog for this.

    coderanger committed Jun 7, 2017
  2. Don’t run the open source tag by default.

    This disables FC078 by default under the reasoning that the majority of Chef developers are not releasing their code on Supermarket, and so we should make that the default here too.
    coderanger committed Jun 7, 2017
Commits on May 26, 2017
  1. Merge pull request #640 from Foodcritic/old_metadata

    Remove metadata for 12.6/12.7/12.8
    tas50 committed on GitHub May 26, 2017
  2. Merge branch 'master' into old_metadata

    damacus committed on GitHub May 26, 2017
  3. Merge pull request #638 from Foodcritic/specs

    Use the improved spec helper method
    tas50 committed on GitHub May 26, 2017
  4. Update tests for newer versions of Chef

    Signed-off-by: Tim Smith <tsmith@chef.io>
    tas50 committed May 26, 2017