Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Epic fail fail? #13

Closed
acrmp opened this Issue Feb 22, 2012 · 5 comments

Comments

Projects
None yet
2 participants
Owner

acrmp commented Feb 22, 2012

@jaymzh raised this problem initially as part of #10:

Update here on the original request... ~ seems to work on -t but NOT on -f.

If I do

foodcritic -f style,~FC014 foo

and FC014 triggers, it still exits with status 3. But FC014 shouldn't trigger failure in this case...

Owner

acrmp commented Feb 22, 2012

Hi Phil,

I believe this behaviour is because FC014 is tagged with style. You may get the desired behaviour by changing your command-line to:
foodcritic -f style -f ~FC014 foo

See the Cucumber tags documentation for more detail:
https://github.com/cucumber/cucumber/wiki/Tags

If this works for you I'll update our documentation to reflect this.

Cheers,

Andrew.

Collaborator

jaymzh commented Feb 22, 2012

Ohhhhhhhh. It was completely unknown to me that multiple flags were AND'd and coma-separate flags are OR'd. That works great. Thanks.

Collaborator

jaymzh commented Feb 28, 2012

This along with the updates in the other task make this work great.

Collaborator

jaymzh commented Feb 28, 2012

I don't have permission to close this - but I think it can be closed.

acrmp added a commit that referenced this issue Feb 28, 2012

Owner

acrmp commented Feb 28, 2012

Thanks. I'd left this open to remind me to update the docs which has now been done.

@acrmp acrmp closed this Feb 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment