Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise FC003 warning if chef-solo-search is installed #7

Closed
acrmp opened this issue Dec 29, 2011 · 7 comments

Comments

Projects
None yet
2 participants
@acrmp
Copy link
Member

commented Dec 29, 2011

As @tobami mentioned on the general Chef list foodcritic warns when search is used even when users have edelight chef-solo-search installed.
http://lists.opscode.com/sympa/arc/chef/2011-12/msg00352.html

It shouldn't do this.

acrmp added a commit that referenced this issue Dec 29, 2011

FC003: Don't warn if chef-solo-search is available
Per the discussion on the Chef list if the edelight chef-solo-search library is
installed then we don't want to warn, refs #7.
@acrmp

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2011

Miquel, thanks for the feedback.

If you get a chance to test this before I release another version of the gem that would be great.

Thanks,

Andrew.

@tobami

This comment has been minimized.

Copy link

commented Dec 29, 2011

Nice, I'll give that a try

@acrmp

This comment has been minimized.

Copy link
Member Author

commented Dec 31, 2011

Hi - FYI the latest version of the gem on rubygems now has this change.

@tobami

This comment has been minimized.

Copy link

commented Jan 3, 2012

Hi, I finally managed to install the foodcritic gem (I'm new to all that rvm, ruby 1.9.3, nokogiri stuff)
but I get an error

Am I doing something terribly wrong?

@acrmp

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2012

Thank you for taking the time to test this. The error message you are seeing is due to Ruby readline support missing. Normally this happens if the readline headers were not available at the time you installed your ruby.

These links should get you sorted, alternatively if you already have 1.9.2 lying around you can just use that.
http://stackoverflow.com/questions/4385549/no-such-file-to-load-readline
http://beginrescueend.com/packages/readline/

Thanks again,

Andrew.

@tobami

This comment has been minimized.

Copy link

commented Jan 4, 2012

Thanks, that solved the issue.

In any case I tested with the last foodcritic and it works nicely. The only thing I noticed:
If you have both cookbooks and site-cookbooks and for example put the search library in one of them you will still get warnings in the other. That can be solved by having the chef-solo-search library in both cookbook directories.

That means pretty much you can close this issue!

@acrmp

This comment has been minimized.

Copy link
Member Author

commented Jan 4, 2012

Awesome - thanks Miquel.

Good point about site-cookbooks. I'll close this issue but you've made me think foodcritic should accept multiple arguments for cookbook path.

That would be more consistent with the way Chef allows cookbook_path as an array. It would also play better with ack / find.

Thanks!

@acrmp acrmp closed this Jan 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.