Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Ruby 2.4 and fix failing tests #507

Merged
merged 2 commits into from Jan 31, 2017

Conversation

Projects
None yet
3 participants
@tas50
Copy link
Member

commented Jan 25, 2017

Signed-off-by: Tim Smith tsmith@chef.io

Test on Ruby 2.4
Signed-off-by: Tim Smith <tsmith@chef.io>

@tas50 tas50 force-pushed the 24 branch 6 times, most recently from 7c11328 to 55a2c37 Jan 25, 2017

@@ -2,7 +2,7 @@ require "foodcritic/version"
require "bundler"
require "rake/testtask"

task :default => [:man, :install, :rubocop, :test, :features]
task :default => [:man, :install, :test, :features, :rubocop]

This comment has been minimized.

Copy link
@josephholsten

josephholsten Jan 28, 2017

usually I sort these by how long it takes to run, so I'm a bit confused by this change

This comment has been minimized.

Copy link
@tas50

tas50 Jan 28, 2017

Author Member

This is something lamont brought up today and I was running into it. Style is the thing you care about the least and you often fail tests there first, which stops testing. This way you see your failing specs first and you can clean up your style later. It avoids multiple commits to style.

This comment has been minimized.

Copy link
@lamont-granquist

lamont-granquist Jan 31, 2017

Collaborator

yeah it annoys the crap out of me to have rubocop fail first because fixing that is usually mindless.

@tas50 tas50 force-pushed the 24 branch 3 times, most recently from 76fab5c to e2ff640 Jan 28, 2017

Fix a few failing tests
Signed-off-by: Tim Smith <tsmith@chef.io>

@tas50 tas50 changed the title Test on Ruby 2.4 Test on Ruby 2.4 and fix failing tests Jan 29, 2017

@tas50

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2017

I've removed the tests that check for the exist status as these all fail now. Our default behavior is now to fail on any failing tag. If we generate a cookbook that lacks basic things like metadata it will ALWAYS fail a tag and thus always exit non-0. There's no way to test this in the current design of the tests / app.

@tas50 tas50 requested a review from lamont-granquist Jan 29, 2017

@tas50 tas50 merged commit efc4095 into master Jan 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tas50 tas50 added the Enhancements label Jan 31, 2017

@tas50 tas50 deleted the 24 branch Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.