Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new from_hash feature and fixed the documentation. #18

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
3 participants
@ibarrajo
Copy link

commented Jul 18, 2014

I did multiple changes on the project.

  • Fixed the documentation in the README.md and added tons of markdown.
  • Created demo directory with the page from: http://www.checkman.io/please/
  • Added a new feature that maps any string to the same color every time. (useful for use with ChartJS)

ibarrajo added some commits Jul 18, 2014

Added new feature that maps any string to a color, see the docs.
Renamed the license because of typo in filename.
Updated bower.json with new author
created demo directory with example documentation

Renamed MIT license with typo in name.
@ibarrajo

This comment has been minimized.

Copy link
Author

commented Jul 18, 2014

I missed to comment-out a console.log on line 253, once it's merged can @Fooidge patch it?

ibarrajo added some commits Jul 20, 2014

Renamed the files to lower case, created gulp script, updated package…
….json, created a distribution directory, added a license header, and fixed all of the JSHint hiccups it was trowing.
@ibarrajo

This comment has been minimized.

Copy link
Author

commented Jul 20, 2014

My fork has diverged quite a bit, it's still 100% compatible, but the patch files are huge.

I added a GulpJS build script and cleaned up the code to pass JSHint.

@Fooidge Tell me if you're interested in merging it.
https://github.com/ibarrajo/PleaseJS

@ibarrajo ibarrajo closed this Jul 20, 2014

@Fooidge

This comment has been minimized.

Copy link
Owner

commented Jul 21, 2014

I've been away for bit. Had some opportunities come up in large part due to the overwhelming response to Please.

I'd love it if you could reopen your branch. I have some changes I'd like to make but a great deal of it will certainly go in.

Thanks a bunch,
Jordan

On Jul 20, 2014, at 7:53 PM, Josue A. Ibarra notifications@github.com wrote:

Closed #18.


Reply to this email directly or view it on GitHub.

@ibarrajo

This comment has been minimized.

Copy link
Author

commented Jul 21, 2014

Ok, I see there are some merge conflicts, I'll get to them later this afternoon.

On Mon, Jul 21, 2014 at 12:25 PM, Jordan Checkman notifications@github.com
wrote:

I've been away for bit. Had some opportunities come up in large part due
to the overwhelming response to Please.

I'd love it if you could reopen your branch. I have some changes I'd like
to make but a great deal of it will certainly go in.

Thanks a bunch,
Jordan

On Jul 20, 2014, at 7:53 PM, Josue A. Ibarra notifications@github.com
wrote:

Closed #18.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#18 (comment).

@ibarrajo ibarrajo reopened this Jul 21, 2014

@MaciekBaron

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2014

I've already implemented seed based generation and my pull request is waiting, not sure which solution is better though.

EDIT:
To be honest I think my solution is a bit simpler and can be easily applied to generate any value without creating a separate case for it. But Fooidge can decide.

@Fooidge Fooidge closed this Oct 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.