Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact Sources deprecated fields #181

Open
pidydx opened this Issue Jul 9, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@pidydx
Copy link
Contributor

pidydx commented Jul 9, 2016

Should supported_os, conditions, and returned_types be getting removed from sources?
Comments in the code indicate they should be removed.
Documentation on style indicates they are correct.

I think ideally ArtifactDefinition.AppendSource() would create a source with all of its valid fields rather than attaching supported_os, conditions, and returned_types in the ArtifactsReader.
Also Source.CopyToDict() should return the entire Source as dict (type, supported_os if defined, conditions if defined, returned_types if defined, attributes) rather than constructing it in ArtifactWriter.

I didn't want to refactor any of this without knowing what direction supported_os, conditions, and returned_types should be going in.

@joachimmetz joachimmetz self-assigned this Jul 14, 2017

@joachimmetz joachimmetz referenced this issue Jul 14, 2017

Open

Improve validator #216

3 of 11 tasks complete
@joachimmetz

This comment has been minimized.

Copy link
Member

joachimmetz commented Mar 4, 2019

  • returned_types was removed
  • supported_os and conditions need an overhaul, see #274
@joachimmetz

This comment has been minimized.

Copy link
Member

joachimmetz commented Mar 4, 2019

Comments in the code indicate they should be removed.

Note that this project is not the only implementation e.g. GRR has its own artifacts reader implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.