Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last returned_types #316

Closed
cugu opened this Issue Feb 28, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@cugu
Copy link
Contributor

cugu commented Feb 28, 2019

There is only one returned_types remaining: https://github.com/ForensicArtifacts/artifacts/blob/master/data/windows.yaml#L1224

Can this be removed?

@joachimmetz

This comment has been minimized.

Copy link
Member

joachimmetz commented Feb 28, 2019

Related issue: #181

Plaso is not using this. Let me check with the GRR project (@grrrrrrrrr) if they are using this.

https://github.com/ForensicArtifacts/artifacts/blob/master/docs/Artifacts%20definition%20format%20and%20style%20guide.asciidoc#3-sources

@joachimmetz joachimmetz self-assigned this Feb 28, 2019

@joachimmetz

This comment has been minimized.

Copy link
Member

joachimmetz commented Feb 28, 2019

Per @demonchild2112 Removing the field from the only artifact that uses it (WindowsPersistenceMechanisms) should not affect collection logic, so feel free to do so.

@joachimmetz

This comment has been minimized.

Copy link
Member

joachimmetz commented Feb 28, 2019

  • remove from definitions #320
  • have reader / validator report that this keyword is deprecated #321
  • remove from documentation #321

joachimmetz added a commit that referenced this issue Feb 28, 2019

joachimmetz added a commit to joachimmetz/artifacts that referenced this issue Feb 28, 2019

joachimmetz added a commit to joachimmetz/artifacts that referenced this issue Feb 28, 2019

joachimmetz added a commit to joachimmetz/artifacts that referenced this issue Feb 28, 2019

joachimmetz added a commit that referenced this issue Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.