Skip to content

Conversation

@ryanbas21
Copy link
Contributor

@ryanbas21 ryanbas21 commented Nov 14, 2022

it was asked that we link the root README license file section to where the file lives in the javascript-sdk package

JIRA Ticket

Please link jira ticket here

Description

Type of Change

Please Delete options that are not relevant

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Definition of Done

Check all that apply

  • Acceptance criteria is met.
  • All tasks listed in the user story have been completed.
  • Coded to standards.
  • Code peer-reviewed.
  • Ensure backward compatibility (special attention).
  • API reference docs is updated.
  • Unit tests are written.
  • Integration tests are written.
  • e2e tests are written.
  • CI build passing on the feature branch.
  • Functional spec is written/updated
  • contains example code snippets.
  • Change log updated.
  • Documentation story is created and tracked.
  • UI is completed or ticket is created.
  • Demo to PO and team.
  • Tech debts and remaining tasks are tracked in separated ticket(s).

Documentation

  • Acceptance criteria met
  • Spell-check run
  • Peer reviewed
  • Proofread

k
it was asked that we link the root README license file section to where
the file lives in the javascript-sdk package
@nx-cloud
Copy link

nx-cloud bot commented Nov 14, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1da148d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx e2e autoscript-suites
✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@ryanbas21 ryanbas21 temporarily deployed to Preview November 14, 2022 15:11 Inactive
@github-actions
Copy link
Contributor

@ryanbas21 ryanbas21 merged commit 25898c4 into develop Nov 14, 2022
@cerebrl cerebrl deleted the fix-readme-license branch June 12, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants