fix(javascript-sdk): fix-publish-readme-and-dist #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanbas21
commented
Apr 12, 2023
| "packageJsonDir": "dist/packages/${PROJECT_NAME}", | ||
| "gitAssets": ["packages/${PROJECT_NAME}/README.md", "packages/${PROJECT_NAME}/CHANGELOG.md"], | ||
| "gitAssets": [ | ||
| "!dist/*", |
Contributor
Author
There was a problem hiding this comment.
this should ignore dist so we shouldn't commit it back to the repo.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2a06503. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
ignore dist in semantic release explicitly. it shouldnt be comitted. add assets object so that readme is copied over to dist
ryanbas21
force-pushed
the
fix-project-dist
branch
from
6ce6a80 to
2a06503
Compare
ryanbas21
commented
Apr 12, 2023
| "github": true, | ||
| "ci": true, | ||
| "commitMessage": "chore(release-${PROJECT_NAME}): ${nextRelease.version} [skip ci]", | ||
| "packageJsonDir": "dist/packages/${PROJECT_NAME}", |
Contributor
Author
There was a problem hiding this comment.
this may have been causing that push, so im gonna hope without this its correct
Contributor
|
Your preview environment pr-339-ryanbas21 has been deployed. Preview environment endpoints are available at: |
cerebrl
approved these changes
Apr 12, 2023
Contributor
Author
|
🎉 This PR is included in version 4.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore dist in semantic release explicitly. it shouldnt be comitted. add assets object so that readme is copied over to dist
JIRA Ticket
Please link jira ticket here
Description
Type of Change
Please Delete options that are not relevant
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Definition of Done
Check all that apply
Documentation