Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Merging Font-Awesome-4.7.0 viewBox specifications #200
One of my projetcs uses
In a nutshell, the sprite file is created with
This process relies on accurate viewBox definitions however, and most of the viewBox definitions from the fontawesome icons under src/icons/svg/ are missing. Additionally, several of the svg width/height specifications seem to be off.
To create a proper sprite file, I've forked the Fork-Awesome repository and re-generated the fontawesome SVG icons. Some icons are not perfectly centered or inconsistently centered (like calendar*.svg), but none of them is clipped or out of bounds.
I intend to fix the centering issues of the fontawesome icons and then add/fix the viewBox of the fork-awesome icons as well. I wonder if any of that should be back folded into ForkAwesome/Fork-Awesome?
The diff is quite significant, especially since the fontawesome paths I could extract seem to differ from the SVG files in ForkAwesome/Fork-Awesome, mostly because the sizing is generally based on 1792x1792 pixels.
The existing viewBox definitions for Fork-Awesome icons also seem to be inconsistent (some use 1792 as height, some 1796, etc) and some are wildely off, to the extend of clipping the actual icons.
So feedback is appreciated, especially about the intended sizes / viewBox the fork-awesome icons should have.
My (local) changes live here atm: https://github.com/tim-janik/Fork-Awesome/commits/master