Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow resizing the commit message area #193
It would be cool if one could resize the commit message area just like one can the staged files area. Especially if you're crafting more verbose commit messages, being cramped into that narrow little text field feels a bit claustrophobic
Thanks for the great work!
This is hijacking the resizing issue a bit, but this seems like the appropriate place to respond to the commit message area changes.
I need to use it a bit more, but my initial impression of this change isn't great. The biggest issue is that if you try to write a commit message by habit, it's not clear what the result actually is.
This feels to me like an example of the UI being helpful, but it breaking the expectations of people who've spent time working at the command line.
In the spirit of constructive criticism, maybe what's need is a much more definitive separation between subject and body. Not necessarily two boxes, but boundary lines, automatic trimming of the top empty space, or something along that path.
@nebhale Thank you very much for the feedback. I think current issue is a good place to discuss the topic.
It was the same before. I received feedback that people are not sure how many space will be placed between. It was a bit more clear though.
My personal feeling about new layout is the following: I like where it goes, but the feature is not final yet. Let's try to improve it and if it won't work out fine, I'll revert my changes.
So, the current problems:
We can add a more clear placeholder which will clarify this. Changing
I can increase the empty space between Subject and Description and also add thin horizontal line.
I'll make a mockup on the weekend...
That would be much more obvious.
The keyboard interaction would be interesting to think about as well. Typing a commit message in a standard text editor would be
One thing that keeps nagging at me though is the thought that this might be prescribing too much in the UI. The summary + empty line + description is a convention (recommended certainly) but not a requirement. If you chose to buck this convention, say one big paragraph of text with multiple lines but no empty line, how would you even do that with this UI?
I made another change related to the description field. It's being resized automatically relying on the inner content up to a half of the screen. I also reduced jumping and blinking on focus.
I'm pretty happy with the result and I think we can close the issue once the feature comes out publicly.