New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] UI Issues with macOS 10.14 beta #306

Closed
tomaculum opened this Issue Jun 7, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@tomaculum

tomaculum commented Jun 7, 2018

Hi,

I am running Fork 1.0.67.5 on macOS 10.14 beta (18A293u) and saw some ui issues in the repository view as well as in the repository settings popup.

I assume this is easily reproducible. If not, please let me know and I will provide more information.

Best regards,
Tom

(Default theme and dark theme of Fork (not macOS dark mode))

bildschirmfoto 2018-06-08 um 17 24 55 bildschirmfoto 2018-06-08 um 17 25 20

bildschirmfoto 2018-06-08 um 17 24 32

bildschirmfoto 2018-06-08 um 17 25 46

@DanPristupov

This comment has been minimized.

Contributor

DanPristupov commented Jun 8, 2018

Thank you for reporting that. Did you install the beta on a separate computer or run it as as a virtual machine?

@tomaculum

This comment has been minimized.

tomaculum commented Jun 8, 2018

On a separate computer: MBP10,1
I have noticed this issues in the Fork dark theme as well and updated the screenshots above. And I do not know if this is somehow relevant but if I enable the dark mode in macOS there is no change to the above shown images - no font color change or something I have noticed.

@DanPristupov

This comment has been minimized.

Contributor

DanPristupov commented Jun 11, 2018

OK, I'm going install the Mojave beta as a VM and then have a look at the problems.

@DanPristupov

This comment has been minimized.

Contributor

DanPristupov commented Jun 21, 2018

Just sharing the status. I could not fix the problem yet, it requires more investigation.

@DanPristupov

This comment has been minimized.

Contributor

DanPristupov commented Jul 5, 2018

Tom, I improved a many things and made them available in the 1.0.68.2 prerelease. Could you please try it out? #318

  • Fixed sidebar transparency
  • Fixed incorrect layout in the commit view (lines did not match)
  • The toolbar in the repository settings window was an OS X bug and has been fixed in beta 3.
@DanPristupov

This comment has been minimized.

Contributor

DanPristupov commented Jul 11, 2018

These fixes are available in 1.0.68 update.

@DanPristupov DanPristupov added the done label Jul 11, 2018

@DanPristupov DanPristupov added this to the 1.0.68 milestone Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment