New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use other color to show diff in Diff View #307

Open
Whirlwind opened this Issue Jun 11, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@Whirlwind
Copy link

Whirlwind commented Jun 11, 2018

In dark mode, the diff is red for delete lines and green for add lines, but I am a red and green color blindness. :(

@DanPristupov

This comment has been minimized.

Copy link
Contributor

DanPristupov commented Jun 11, 2018

Can you provide any info how developers should solve such kind of problems?

@Whirlwind

This comment has been minimized.

Copy link
Author

Whirlwind commented Jun 11, 2018

The SourceTree:
image
First, there is a + and -, this is very clear.
Then the color is not red and green, and sourcetree app allow user custom the color.

@nebhale

This comment has been minimized.

Copy link

nebhale commented Jun 11, 2018

@DanPristupov I've not evaluated this directly, but the company I work for use Color Oracle during design work to simulate these scenarios. There are macOS native apps such as Sim Daltonism as well.

@DanPristupov

This comment has been minimized.

Copy link
Contributor

DanPristupov commented Jun 11, 2018

@nebhale Sim Daltonism is a great application, thank you.

Here's how Fork looks. Seems to be confusing indeed.
2018-06-11 at 20 24

I'm not ready to change whole application palette, but I can introduce a color-blind mode with more distinctive highlighting colors and additional - + signs. Local/Remote branch colors could be improved too.

Few questions to @Whirlwind :

  1. What about GitHub palette? It should be quite bad, right?

2018-06-11 at 20 37

  1. Do you use any special appearance settings in macOS?
@Whirlwind

This comment has been minimized.

Copy link
Author

Whirlwind commented Jun 12, 2018

What about GitHub palette? It should be quite bad, right?

There are multi ways to make a difference in diff view in the Github:

  1. different color in line number column , it is clear.
  2. different color for text background color, it is bad.
  3. Highlight for changed text, it is clear.
  4. + and - is very clear.

Do you use any special appearance settings in macOS?

No, I just use the dark style in the Fork.

@Whirlwind

This comment has been minimized.

Copy link
Author

Whirlwind commented Jun 12, 2018

By the way, the color-blind have multi type, not just red and green.

@luong-komorebi

This comment has been minimized.

Copy link

luong-komorebi commented Jul 12, 2018

image
My experiece in dark mode and when two changes sit next to each other is even much more challeging. I suggest that we

  1. if possible, enable side by side diff view
  2. Change the color scheme of the diff, or let users change it, customize it the way they want.
@DanPristupov

This comment has been minimized.

Copy link
Contributor

DanPristupov commented Feb 1, 2019

In 1.0.73 we used better colors in the dark theme.

@DanPristupov DanPristupov reopened this Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment