New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Diff view doesn't scroll to top automatically #326

Closed
chiahsien opened this Issue Jul 4, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@chiahsien

chiahsien commented Jul 4, 2018

When I select a file, the diff view doesn't scroll to top automatically.

So I have to scroll to top manually (if the diff is more than one page long) every time when I select a file. I believe this should be a bug.

@maksimovic

This comment has been minimized.

maksimovic commented Jul 16, 2018

True. It's not a big deal usually, but these days it's bugging me more than usually since I'm on a mission to refactor big chunks of code, and self-code-review is itching me a bit because of this.

@DanPristupov

This comment has been minimized.

Contributor

DanPristupov commented Jul 17, 2018

Ideally Fork must use a cache of the recent file scroll positions, where the key is sha+filepath and the value is actually the position.

@chiahsien

This comment has been minimized.

chiahsien commented Jul 18, 2018

So, because something wrong with the cache design, first selected file doesn't scroll to top? Is it hard to fix? I can imagine it would be useful when I need to code-review and switch files back and forth.

@DanPristupov DanPristupov added this to the 1.0.70 milestone Sep 13, 2018

@DanPristupov

This comment has been minimized.

Contributor

DanPristupov commented Sep 17, 2018

I just released 1.0.70 which automatically remembers and restores the scrollbar position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment