Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] toggle tags in commit list #402

Closed
AlexTugarev opened this issue Sep 11, 2018 · 8 comments

Comments

@AlexTugarev
Copy link

commented Sep 11, 2018

it would be awesome to make rendering of tags in the commit list optional. for instance in projects with CD pipelines, it can be really noisy.

@DanPristupov

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2018

Hi. Do you need the tags at all? Can that be a solution for you? #403

@AlexTugarev

This comment has been minimized.

Copy link
Author

commented Sep 14, 2018

hi @DanPristupov! to delete all tags locally would be a valid workaround in one project. thanks!

in other projects I need those git tags, but not all the time. it would be still a practical thing to toggle them in the view.

@DanPristupov

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2018

I just checked, I can add an option to hide tags.

Could tell a bit more about your use case?

  • I suppose you need this option enabled only for some repositories, not for the whole application, right?
  • Should the state persist after restart?
  • Do you still want to see tags on the sidebar?
@maksimovic

This comment has been minimized.

Copy link

commented Sep 16, 2018

+1 for this, too. Also, answers to the questions above in my case:

  • Only for some repositories, not for the whole application
  • The state should persist after restart
  • No, for such repositories tags are completely irrelevant

While we're here (tags-related discussion), it's quite annoying that tags remain expanded after canceling the search. I've got around 7k tags in one repo and it's frustrating to sometimes scroll into that huge list which cannot be collapsed via keyboard shortcut (that I know of), then having to scroll up to find the arrow and collapse it back using the mouse 😬

@DanPristupov

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

@maksimovic great feedback as always! I'll rush to include this feature in the 1.0.70 update.

Not sure how to solve the expanded item after search though, but will create a task to not forget about this.

@DanPristupov DanPristupov added this to the 1.0.70 milestone Sep 17, 2018

@DanPristupov DanPristupov added the done label Sep 17, 2018

@DanPristupov

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

  • 1.0.70
@AlexTugarev

This comment has been minimized.

Copy link
Author

commented Sep 19, 2018

Thanks @DanPristupov this works great!

@DanPristupov

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2018

@AlexTugarev cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.