Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit button sometimes disabled after failed commit #565

Closed
marcomasser opened this issue Mar 7, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@marcomasser
Copy link

commented Mar 7, 2019

When committing fails at the Git level (like in the attached GIF – sorry for the black bars – where I entered an incorrect PIN for the hardware authentication device that stores the private key for signing the commits using GPG), Fork shows a window-modal sheet with Git’s error output. Closing that sheet returns the UI to the usual state, but the commit button is disabled.

disabled commit button copy

There doesn’t seem to be a way to re-enable it except changing the whole view, e.g. clicking “All Commits” in the left sidebar and then back again.

@DanPristupov DanPristupov added this to the 1.0.75 milestone Mar 7, 2019

@DanPristupov

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Thank you for reporting that. I've reproduced the problem.

@marcomasser

This comment has been minimized.

Copy link
Author

commented Mar 7, 2019

Man, you’re fast! 🏎

@DanPristupov

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Fixed in 1.0.75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.