From 0a21e43122f88debaa37c706f8c96b09e9c0a620 Mon Sep 17 00:00:00 2001
From: Ryan Roemer <ryan@loose-bits.com>
Date: Wed, 13 Apr 2016 16:31:54 -0700
Subject: [PATCH] BUG: Allow root package.json to omit config.

* Add permissive traverse of package.json's when searching for configs. Fixes #113
* Add regression test.
---
 lib/config.js                             |  4 +--
 test/server/spec/bin/builder-core.spec.js | 33 +++++++++++++++++++++++
 2 files changed, 35 insertions(+), 2 deletions(-)

diff --git a/lib/config.js b/lib/config.js
index 2b15bfb..97cf852 100644
--- a/lib/config.js
+++ b/lib/config.js
@@ -215,9 +215,9 @@ Config.prototype._displayFields = function (field, archetypes) {
   // Then, map in order.
   return _.map(keys, function (key) {
     var tasks = _.chain(pkgs)
-      .filter(function (pkg) { return pkg[field][key]; })
+      .filter(function (pkg) { return _.get(pkg, [field, key]); })
       .map(function (pkg) {
-        return "\n    " + chalk.gray("[" + pkg.name + "]") + " " + pkg[field][key];
+        return "\n    " + chalk.gray("[" + pkg.name + "]") + " " + _.get(pkg, [field, key]);
       })
       .value()
       .join("");
diff --git a/test/server/spec/bin/builder-core.spec.js b/test/server/spec/bin/builder-core.spec.js
index 9ee6c13..96fc70e 100644
--- a/test/server/spec/bin/builder-core.spec.js
+++ b/test/server/spec/bin/builder-core.spec.js
@@ -216,6 +216,38 @@ describe("bin/builder-core", function () {
         done();
       });
     });
+
+    // Regression test for: https://github.com/FormidableLabs/builder/issues/113
+    it("runs help with config in archetype", function (done) {
+      base.sandbox.spy(Task.prototype, "help");
+      base.mockFs({
+        ".builderrc": "---\narchetypes:\n  - mock-archetype",
+        "package.json": "{}",
+        "node_modules": {
+          "mock-archetype": {
+            "package.json": JSON.stringify({
+              "config": {
+                "_test_message": "from archetype"
+              }
+            }, null, 2)
+          }
+        }
+      });
+
+      run({
+        argv: ["node", "builder", "help"]
+      }, function (err) {
+        if (err) { return done(err); }
+
+        expect(Task.prototype.help).to.be.calledOnce;
+        expect(logStubs.info)
+          .to.be.calledWithMatch("Task Configs").and
+          .to.be.calledWithMatch("_test_message");
+
+        done();
+      });
+    });
+
   });
 
   describe("builder run", function () {
@@ -265,6 +297,7 @@ describe("bin/builder-core", function () {
       });
 
     }));
+
     it("runs with quiet log output", stdioWrap(function (done) {
       base.sandbox.spy(Task.prototype, "run");
       base.mockFs({