New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: isBuilderTask doesn't correctly infer on Windows. #140

Merged
merged 7 commits into from Apr 10, 2017

Conversation

Projects
None yet
3 participants
@ryan-roemer
Member

ryan-roemer commented Apr 7, 2017

Confusingly lots of stuff here...

  • Actual issue: Fix builder passthrough determination on Windows. This is just @GEMI 's fix from #139 that I've copied with lots of other stuff going on. Fixes #138
  • Travis CI fails weirdly from an istanbul / node-mkdirp issue on Node 6's somewhere by 6.10.2. I've captured the issue in a ticket and just pinned 6.9.2
  • I've honed down the .npmignore to make the package smaller.
  • Removed npm@2 from testing on Node 5 and 6.

/cc @GEMI

ryan-roemer added some commits Apr 7, 2017

@coveralls

This comment has been minimized.

coveralls commented Apr 7, 2017

Coverage Status

Coverage remained the same at 93.739% when pulling 58320e5 on bug/win-isBuilderTask into 25385e4 on master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Apr 7, 2017

Coverage Status

Coverage remained the same at 93.739% when pulling 58320e5 on bug/win-isBuilderTask into 25385e4 on master.

@ryan-roemer

This comment has been minimized.

Member

ryan-roemer commented Apr 7, 2017

CI failures in node6 may be related to: substack/node-mkdirp#110

@coveralls

This comment has been minimized.

coveralls commented Apr 10, 2017

Coverage Status

Coverage remained the same at 93.739% when pulling 91ec901 on bug/win-isBuilderTask into 25385e4 on master.

@coveralls

This comment has been minimized.

coveralls commented Apr 10, 2017

Coverage Status

Coverage remained the same at 93.739% when pulling e7d3f48 on bug/win-isBuilderTask into 25385e4 on master.

@coveralls

This comment has been minimized.

coveralls commented Apr 10, 2017

Coverage Status

Coverage remained the same at 93.739% when pulling 1c1876e on bug/win-isBuilderTask into 25385e4 on master.

@ryan-roemer ryan-roemer changed the title from [WIP] BUG: isBuilderTask doesn't correctly infer on Windows. to BUG: isBuilderTask doesn't correctly infer on Windows. Apr 10, 2017

@ryan-roemer

This comment has been minimized.

Member

ryan-roemer commented Apr 10, 2017

@GEMI -- I've got a replacement for your #139 PR because there was a lot of totally unrelated stuff it took to make travis happy. Can you pull down the PR and make sure it still works for you?

I've added attribution to you for HISTORY.md, but if I merge this PR you won't actually have commit history attribution because I copied and pasted -- is that OK?

Thanks!

@coveralls

This comment has been minimized.

coveralls commented Apr 10, 2017

Coverage Status

Coverage remained the same at 93.739% when pulling a2ec3d0 on bug/win-isBuilderTask into 25385e4 on master.

@GEMI

This comment has been minimized.

GEMI commented Apr 10, 2017

Sure do whatever you want. It's your project :)

@ryan-roemer ryan-roemer merged commit 37e33da into master Apr 10, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.739%
Details

@ryan-roemer ryan-roemer deleted the bug/win-isBuilderTask branch Apr 10, 2017

@ryan-roemer

This comment has been minimized.

Member

ryan-roemer commented Apr 10, 2017

Released in builder@3.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment