This repository was archived by the owner on Mar 4, 2022. It is now read-only.
Move customization to layout generation #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscottx88
approved these changes
Dec 19, 2017
Contributor
mscottx88
left a comment
mscottx88
left a comment
There was a problem hiding this comment.
This looks good, nice.
Contributor
Author
|
PR #87 also changes this code. It uses the same method but in a different location. |
ryan-roemer
approved these changes
Dec 26, 2017
Member
ryan-roemer
left a comment
ryan-roemer
left a comment
There was a problem hiding this comment.
One minor nit to refactor, rest LGTM
lib/generate-layouts.js
Outdated
| } | ||
| return _.merge(view, { view: customization }); | ||
| }); | ||
| return customized; |
Member
There was a problem hiding this comment.
Variable customized unneeded. Just return the .map()
Remove `customized` variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layouts can be customized via a settings file. Move code to apply this to the generate layout function. This make it so the panels config doesn't need to change during the program.
This feature will be used in a future PR.