This repository was archived by the owner on Mar 4, 2022. It is now read-only.
Support layouts in layouts #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjasonclark
force-pushed
the
panel_class
branch
2 times, most recently
from
87cbfd6 to
c41dbed
Compare
Create a Panel class to handle all layout Move view creation into its own file Dynamically convert all configs into panels
jjasonclark
force-pushed
the
panel_class
branch
from
c41dbed to
af3ec22
Compare
mscottx88
reviewed
Dec 21, 2017
Contributor
mscottx88
left a comment
mscottx88
left a comment
There was a problem hiding this comment.
Code looks good. I'm going to play with the tool and check out these new behaviors!
Contributor
Author
|
Check out https://github.com/jjasonclark/nodejs-dashboard/blob/platform-details-view/lib/default-layout-config.js#L124-L165 for a sample layout using the new details views. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layouts only work in one direction, columns then rows. This change allows layouts in layouts so you can make more complex layouts.
Panels now handle layout. Panels can create sub views, including more panels. The initial layout file read method adds a bit to the result to assume the outer most array of views is a panel. Then normal view creation is used to kick off the whole screen layout.
view/index.jsPanelclass to handle layoutsThis includes much of the changes from PR #83 to create a view factory