This repository was archived by the owner on Mar 4, 2022. It is now read-only.
Create views for platform information #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create CpuDetailsView to show model and speed of cpus Create EnvDetailsView to show environment variables Create NodeDetailsView to show running node version Create SystemDetailsView to show running platform details Create UserDetailsView to show user information
jjasonclark
force-pushed
the
detail-views
branch
from
31cd6e0 to
b3c7bcf
Compare
mscottx88
approved these changes
Dec 28, 2017
Contributor
mscottx88
left a comment
mscottx88
left a comment
There was a problem hiding this comment.
Looks great man. Do they still get the ability to filter the environment variables?
Contributor
Author
|
No. I figured we could use the views while we figure out how to handle the keyboard stuff. Depending on the order we check in this PR and #87 we can also include a layout that uses all of these views. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create CpuDetailsView to show model and speed of cpus
Create EnvDetailsView to show environment variables
Create NodeDetailsView to show running node version
Create SystemDetailsView to show running platform details
Create UserDetailsView to show user information