This repository was archived by the owner on Dec 15, 2018. It is now read-only.
Fix duplicate basenames in hrefs; avoid matching against full URL #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pathname instead of the url to avoid hardcoded base names
| const LEFT_MOUSE_BUTTON = 0; | ||
|
|
||
| const normalizeHref = location => | ||
| `${location.basename || ''}${location.pathname}`; |
Contributor
There was a problem hiding this comment.
Do we validate basename to ensure it includes a / char?
Contributor
Author
There was a problem hiding this comment.
I'm 95.2345% sure history does this under the hood when you call history.createLocation()
Contributor
|
LGTM! |
adamshone
pushed a commit
to adamshone/redux-little-router
that referenced
this pull request
Oct 21, 2016
…r single children
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
history.createHref()adds duplicate basenames to thehref(remix-run/history#169). This solves that.When matching routes, we matched against
urlinstead ofpathname, which ended up forcing you to hard-code basenames in your routes. This fixes that too!