Vector Icon Support #209

Open
BrandonBoone opened this Issue Oct 5, 2016 · 2 comments

Projects

None yet

2 participants

@BrandonBoone

I'm looking into adding the fontawesome vector icon set to my presentation. It would be great if vector icon support was built and configurable (perhaps as part of the theme option). If I get it working I'll submit a pull request.

@kenwheeler
Member

Is there a configuration preventing it from working properly? I'm wary to add it to core, but totally open to removing any friction to adding it.

@BrandonBoone

There wasn't anything in the project that was actually blocking me from accomplishing this. For whatever reason, my initial thinking was that I needed to have an <Icon> component to render <i class=""></i> baked into the library. I actually did create this component (basically a copy and past of another component), and using the boilerplate as a template, I added font-awesome and font-awesome-webpack. In hindsight, this was probably overkill as I could have just used an <i className=""></i> directly and perhaps even just pulled fontawesome from a CDN.... :-/

Oh, well... It's working nonetheless, and the presentation went over well!.

Anyway, fontawesome does pair rather nicely. While it may be overkill for the core library, you could consider it for the boilerplate.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment