Call For Input: Theming #229

Open
kenwheeler opened this Issue Oct 25, 2016 · 6 comments

Projects

None yet

2 participants

@kenwheeler
Member

Hey EVERYONE. Been debating the merits of switching from inline styles back to a stylesheet based theming approach. Would love to hear what people have to say about that. Thumbs up for CSS, thumbs down for inline styles.

@kwelch
kwelch commented Oct 25, 2016

Is there a specific CSS solution in mind to use?

@kenwheeler
Member

not yet, certainly open to suggestions

@kwelch
kwelch commented Oct 25, 2016

One thing I really liked with react-toobox is that they apply styling using an HOC and also export the unstyled components. That is one flexible way to handle it, but I am not sure how well that concept would apply to spectacle. Just an idea.

@kenwheeler
Member

I mean, inline styles are an inevitability for things like fragments and transitions. I was thinking more along the lines of class names on markdown generated components and having a style sheet

@kenwheeler
Member

Probably some kind of PostCSS setup

@kenwheeler
Member
kenwheeler commented Oct 25, 2016 edited

I want to keep the main API external API the same though, like support and and

and

. Or #H1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment