[Docs] New website #1109
Merged
[Docs] New website #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Checked out https://formidable-com-spectacle-staging-1109.surge.sh/open-source/spectacle/ a bit and looks great so far!!! |
ryan-roemer
reviewed
Apr 27, 2022
ryan-roemer
reviewed
Apr 27, 2022
removing the requirement for noMargin and noPadding misc code cleanup
cleanup and consistency
i have removed the autoPlay prop as it crashes the app at the terminal. made some comments as a reminder of the issue
gksander
reviewed
Aug 8, 2022
Contributor
gksander
left a comment
gksander
left a comment
There was a problem hiding this comment.
This is a chonky PR, but this thing is slick. I dropped a few comments here for us to address real quick, but nothing major. I think we do a little bit of tidying up (I can actually get started on that), get a final design stamp of approval on this, and ship this thing!
carloskelly13
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
react-staticsite with a new one backed bydocusaurus./docsand all docusaurus-related code is located in the new/websitefolder.Type of Change
How Has This Been Tested?
Local testing through
yarn startin/website.Checklist: (Feel free to delete this section upon completion)