Use babel-core polyfill for Safari. #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari lacks es6 Object.assign. This uses the solution from http://stackoverflow.com/a/32917654 to add the babel-core polyfill which fixes support for Safari (and potentially other polyfills?).
Contributor
|
good catch! @kenwheeler we want that ☝️ |
kenwheeler
added a commit
that referenced
this pull request
Dec 11, 2015
Use babel-core polyfill for Safari.
Contributor
|
@threeve Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari lacks es6 Object.assign. This uses the solution from
http://stackoverflow.com/a/32917654 to add the babel-core polyfill which
fixes support for Safari (and potentially other polyfills?).
Not entirely sure this is the right solution, but it does work for me. Tested by making the same changes to the webpack.config.js files in spectacle-boilerplate.