Skip to content

Added <Appear /> order prop. #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2017
Merged

Added <Appear /> order prop. #400

merged 1 commit into from
Nov 7, 2017

Conversation

@carloskelly13
Copy link
Contributor

@carloskelly13 carloskelly13 commented Nov 7, 2017

  • Keep current behavior of <Appear /> tags displaying in order of their JSX order
  • Allow out-of-order <Appear /> tags with an order prop.
  • If a slide contains ordered and unordered <Appear /> tags, show the unordered first
  • Add tests for both conditions

Addresses #346

@carloskelly13 carloskelly13 merged commit e28ece5 into master Nov 7, 2017
@carloskelly13 carloskelly13 deleted the feature/appear-ordering branch November 7, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kenwheeler kenwheeler kenwheeler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carloskelly13 @kenwheeler