Add bgLighten to Base #446
Conversation
kitten
left a comment
kitten
left a comment
There was a problem hiding this comment.
Looks pretty great! 😬 I’m wondering whether it’d make sense to unify these props so that they don’t conflict as much (maybe negative numbers for darken? Or custom overlay colours?) cc @kenwheeler
|
Custom overlay colours would be a great one. Something like |
|
Lets do that. That will be tight |
|
Please review and check whether we can continue like this or not. |
| return convertedFontSize; | ||
| }; | ||
|
|
||
| const hexToRGB = function (hex) { |
There was a problem hiding this comment.
Instead of maintaining this piece of code ourselves it should probably use a helper. Polished has some excellent ones and we won't need to pull in the entire library ✨
https://polished.js.org/docs/#transparentize
or
| bgImage, | ||
| bgDarken, | ||
| bgOverlayColour, | ||
| bgOverlayIntensity, |
There was a problem hiding this comment.
I wouldn't call this prop "intensity" as that would refer to the saturation of the colour: https://www.uwgb.edu/heuerc/2D/ColorTerms.html
Instead I would just call this "opacity" or "opacify" or "transparentize" depending on what it'll do.
There was a problem hiding this comment.
Its bgTransparentize now ✨
|
Can you verify if I did it right? @philpl |
|
@kitten @kenwheeler Can you check? |
|
Hey @aravindballa thank you so much for your work on this! I am closing this since the functionality was added in #531 (along with some other changes we needed), which will be merged soon. |
4 participants
Fixes #445
Added a new prop
bgLightento Base so that it supports lightening images.Screenshot: