Skip to content

Conversation

@ryan-roemer
Copy link
Member

@ryan-roemer ryan-roemer commented Mar 19, 2018

  • Add ESM es/ directory and package.json:module field. Fixes Infra: Add ESM output. #491
  • Enables webpack tree-shaking. Fixes many spectacle dependencies bloats my bundle #490
  • Update to babel 7
  • Refactor all es7 method arrow funcs (foo = () => {}) to real methods (foo() {}). (Just ones that are class methods, not generic arrow funcs).
  • Update one-page files with modern includes and catching up to the full Spectacle API.
  • Add example to lint
  • Add builder to run all our different builds concurrently for speedup.
  • Update travis config

/cc @kenwheeler @carlospaelinck

constructor() {
super();
constructor(props) {
super(props);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also pass context? I know theming uses it. (Same with other components)

Or alternatively

constructor() {
  super(...arguments);

@ryan-roemer ryan-roemer merged commit f578f8e into master Mar 20, 2018
@ryan-roemer ryan-roemer deleted the chore/esm branch March 20, 2018 02:09
@ryan-roemer
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants