Feature/add bg lighten #531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2018 10:45
Fixes #445 * Add bgLighten prop to base.js * Add bgLighten prop description to README.md * Add console warning for bgLighten and bgDarken
Member
|
Have these files (like the readme) been run through prettier? (We’ve got a lot of unrelated formatting changes — we can probably roll with it here for an otherwise small pr, but we typically like to keep prs focused on “just one thing”) |
Contributor
Author
|
README.md was logging an error on commit. The file hadn't been through prettier yet. To commit and pass the tests, I ran prettier on README.md. |
Member
|
Thanks @sam-whale -- we'll fix this after this PR in #532 |
Closed
Contributor
|
sorry @samwhale this got added in a larger PR so I am closing this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445