Skip to content

Use th for TableHeader #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Use th for TableHeader #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/__snapshots__/table-header-item.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`<TableHeaderItem /> should render correctly 1`] = `
<TableHeaderItem>
<Styled(td)
<Styled(th)
styles={
Array [
Object {
Expand All @@ -14,11 +14,11 @@ exports[`<TableHeaderItem /> should render correctly 1`] = `
]
}
>
<td
<th
className="css-4x5e e51bxha0"
>
Header Text
</td>
</Styled(td)>
</th>
</Styled(th)>
</TableHeaderItem>
`;
2 changes: 1 addition & 1 deletion src/components/table-header-item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import { getStyles } from '../utils/base';
import styled from 'react-emotion';

const StyledTableHeaderItem = styled.td(props => props.styles);
const StyledTableHeaderItem = styled.th(props => props.styles);

export default class TableHeaderItem extends Component {
render() {
Expand Down