Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
sofiapoh left a comment
Looks good! This is a very welcome change and improvement for developer experience.
I think it might be nicer to look at the fixtures if we could move some of the mock data to a separate file/bottom of the file, just a lot of visual clutter before we get to the actual test. What do you think?
I also noticed you removed
@sofiapoh yeah I'm down for colocating data if you have suggestions on how we could do that!
I found that most fixtures require very specific mocked states (usually unrelated to other fixtures) so I'm not sure how/if we would should merge them into one. I've gone as far as to not share any values between fixtures because deeply nested spreading hasn't been fun and its felt easier to just copy-paste/simulate real world values - but maybe there's a better way to do this!
It's back! Disabled it while trying to hook up context