Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tooltips to the Event Timeline #109

Merged
merged 5 commits into from Mar 13, 2020
Merged

Conversation

@wgolledge
Copy link
Contributor

wgolledge commented Mar 12, 2020

Changes

  • adds <TimelineTooltip /> and associated useTooltip hook
  • tooltip is displayed/hidden by by setting the ref on the desired element to be the one exposed by useTooltip
  • adds tracks the position of the tooltip via mouse events and via MutationObserver/ResizeObserver
@wgolledge wgolledge changed the title Event timeline tooltip Add Tooltips to the Event Timeline Mar 12, 2020
@wgolledge wgolledge force-pushed the event-timeline-tooltip branch from 06e4345 to 755484a Mar 12, 2020
@wgolledge wgolledge marked this pull request as ready for review Mar 13, 2020
@wgolledge wgolledge merged commit ec2f219 into event-timeline Mar 13, 2020
4 of 6 checks passed
4 of 6 checks passed
ci/circleci: build Your tests failed on CircleCI
Details
ci/circleci: visual regression Your tests failed on CircleCI
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@wgolledge wgolledge deleted the event-timeline-tooltip branch Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.