Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimelinePane to the Timeline #113

Merged
merged 6 commits into from Mar 18, 2020
Merged

Add TimelinePane to the Timeline #113

merged 6 commits into from Mar 18, 2020

Conversation

@wgolledge
Copy link
Contributor

wgolledge commented Mar 17, 2020

Changes

  • Add basic implementation
  • Add corresponding and fixtures
  • Introduce concept of a selected event to Timeline
  • Add onClick to to select the event

Outstanding points

@andyrichardson andyrichardson requested a review from sofiapoh Mar 17, 2020
Copy link
Contributor

andyrichardson left a comment

If we can get away with static panel sections - awesome!

Other than that everything else is a nitpick - good job 🔥

src/panel/context/Events.tsx Outdated Show resolved Hide resolved
src/panel/pages/events/components/EventPane.tsx Outdated Show resolved Hide resolved
src/panel/pages/timeline/Timeline.tsx Show resolved Hide resolved
src/panel/pages/timeline/components/TimelinePane.tsx Outdated Show resolved Hide resolved
@wgolledge wgolledge merged commit 071875f into event-timeline Mar 18, 2020
7 of 11 checks passed
7 of 11 checks passed
ci/circleci: build Your tests failed on CircleCI
Details
ci/circleci: visual regression Your tests failed on CircleCI
Details
Mixed content - urql-devtools
Details
Redirect rules - urql-devtools
Details
Header rules - urql-devtools No header rules processed
Details
Pages changed - urql-devtools 2 new files uploaded
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
netlify/urql-devtools/deploy-preview Deploy preview ready!
Details
@wgolledge wgolledge deleted the event-timeline-pane branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.