Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TimelinePane to the Timeline #113

Merged
merged 6 commits into from Mar 18, 2020
Merged

Add TimelinePane to the Timeline #113

merged 6 commits into from Mar 18, 2020

Conversation

wgolledge
Copy link
Contributor

@wgolledge wgolledge commented Mar 17, 2020 •
edited

Changes

  • Add basic implementation
  • Add corresponding and fixtures
  • Introduce concept of a selected event to Timeline
  • Add onClick to to select the event

Outstanding points

andyrichardson
andyrichardson approved these changes Mar 17, 2020
View reviewed changes
Copy link
Collaborator

@andyrichardson andyrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can get away with static panel sections - awesome!

Other than that everything else is a nitpick - good job 🔥

sofiapoh
sofiapoh approved these changes Mar 18, 2020
View reviewed changes
src/panel/context/Events.tsx Outdated Show resolved Hide resolved
src/panel/pages/events/components/EventPane.tsx Outdated Show resolved Hide resolved
src/panel/pages/timeline/Timeline.tsx Show resolved Hide resolved
src/panel/pages/timeline/components/TimelinePane.tsx Outdated Show resolved Hide resolved
@wgolledge wgolledge merged commit 071875f into event-timeline Mar 18, 2020
@wgolledge wgolledge deleted the event-timeline-pane branch March 18, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyrichardson andyrichardson andyrichardson approved these changes

@sofiapoh sofiapoh sofiapoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wgolledge @andyrichardson @sofiapoh