Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ticks + zoom scaling #114

Merged
merged 14 commits into from Mar 18, 2020
Merged

Add ticks + zoom scaling #114

merged 14 commits into from Mar 18, 2020

Conversation

@andyrichardson
Copy link
Contributor

andyrichardson commented Mar 17, 2020

About

  • Add ticks to timeline
  • Add zooming and panning (scaled)
  • Trim height of timeline-row durations

COSMOS

Notes

  • Does scroll + zoom feel intuitive/obvious?
@andyrichardson andyrichardson requested review from wgolledge and sofiapoh Mar 17, 2020
.eslintrc Outdated
@@ -10,8 +10,15 @@
"plugin:react/recommended"
],
"rules": {
"import/order": 2,
"@typescript-eslint/no-unused-vars": 2,
"import/order": ["error", { "newlines-between": "never" }],

This comment has been minimized.

Copy link
@wgolledge

wgolledge Mar 18, 2020

Contributor

Super nit picky: it could be good to have the lint rules in some sort of order?

This comment has been minimized.

Copy link
@andyrichardson

andyrichardson Mar 18, 2020

Author Contributor

Are you saying we need to order the import order rule? 😅

src/panel/context/Explorer/ast/index.ts Outdated Show resolved Hide resolved
src/panel/context/Explorer/ast/index.ts Outdated Show resolved Hide resolved
src/panel/context/Explorer/ast/index.ts Outdated Show resolved Hide resolved
src/panel/context/Explorer/ast/index.ts Outdated Show resolved Hide resolved
src/panel/context/Explorer/ast/variables.ts Outdated Show resolved Hide resolved
src/panel/context/Timeline.tsx Show resolved Hide resolved
src/panel/pages/explorer/components/Icons.tsx Outdated Show resolved Hide resolved
src/panel/pages/timeline/Timeline.tsx Show resolved Hide resolved

export const Timeline: FC = () => {
const {
setContainer,
getTimePosition,
scale,

This comment has been minimized.

Copy link
@wgolledge

wgolledge Mar 18, 2020

Contributor

Getting some type errors here

This comment has been minimized.

Copy link
@andyrichardson

andyrichardson Mar 18, 2020

Author Contributor

I think the TS server is using old values after pulling changes - it's passing type checking now 🙏

@wgolledge

This comment has been minimized.

Copy link
Contributor

wgolledge commented Mar 18, 2020

Looking awesome in cosmos!

One slightly strange interaction - I get a horizontal scroll if I vertical scroll when already at the bottom of the container/domain

@andyrichardson

This comment has been minimized.

Copy link
Contributor Author

andyrichardson commented Mar 18, 2020

One slightly strange interaction - I get a horizontal scroll if I vertical scroll when already at the bottom of the container/domain

@wgolledge we should pair on this!

The intention was to allow horizontal scrolling when using a mouse - but this wasn't my brightest of ideas. Lets try out dragging like you suggested!

@andyrichardson andyrichardson merged commit e8f2720 into event-timeline Mar 18, 2020
11 of 12 checks passed
11 of 12 checks passed
ci/circleci: visual regression Your tests failed on CircleCI
Details
Header rules - urql-devtools No header rules processed
Details
Pages changed - urql-devtools 2 new files uploaded
Details
Redirect rules - urql-devtools No redirect rules processed
Details
Mixed content - urql-devtools No mixed content detected
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint firefox Your tests passed on CircleCI!
Details
ci/circleci: prettier Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
netlify/urql-devtools/deploy-preview Deploy preview ready!
Details
@andyrichardson andyrichardson deleted the add-ticks branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.