New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ordered imports #147

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
3 participants
@andyrichardson

andyrichardson commented Dec 3, 2018

No description provided.

@coveralls

This comment has been minimized.

coveralls commented Dec 3, 2018

Coverage Status

Coverage remained the same at 92.082% when pulling d85460c on maintenance/ordered-imports-tslint into 2d701e8 on v1.

@andyrichardson andyrichardson merged commit 7c42c54 into v1 Dec 3, 2018

4 checks passed

bundlesize ./dist/index.mjs: 2.68KB < maxSize 8KB (gzip)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.082%
Details
@kitten

This comment has been minimized.

Member

kitten commented Dec 3, 2018

This is actually a rule we've consciously removed before among others :) It doesn't add any value and is basically just noise. If we only order local vs external imports that'd be sweet, but otherwise let's please remove it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment